public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/8] OMAP3 Add usb device support
Date: Tue, 27 Oct 2009 09:04:20 -0500	[thread overview]
Message-ID: <4AE6FDE4.3050807@windriver.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E73940436E5F61D@dbde02.ent.ti.com>

Gupta, Ajay Kumar wrote:
> Tom,
> 
>> From: Tom Rix <Tom.Rix <at> windriver.com>
>> Subject: [PATCH 4/8] OMAP3 Add usb device support
>> Newsgroups: gmane.comp.boot-loaders.u-boot
>> Date: 2009-09-28 16:37:25 GMT (4 weeks, 12 hours and 29 minutes ago)
>> This change adds the usb device support for musb.
>>
>> Omap3 platform support added at the same level as davinci.
>>
>> The interface for usbtty to use the musb device support was added.
>>
>> Verified on omap3 beagle, zoom1 and zoom2.
>>
>> Signed-off-by: Tom Rix <Tom.Rix <at> windriver.com>
>> ---
>>  drivers/serial/usbtty.h       |    2 +
>>  drivers/usb/musb/Makefile     |    2 +
>>  drivers/usb/musb/musb_core.c  |    8 +-
>>  drivers/usb/musb/musb_core.h  |   40 ++
>>  drivers/usb/musb/musb_debug.h |  205 +++++++++
>>  drivers/usb/musb/musb_udc.c   |  963
>> +++++++++++++++++++++++++++++++++++++++++
>>  drivers/usb/musb/omap3.c      |  129 ++++++
>>  drivers/usb/musb/omap3.h      |   48 ++
>>  include/usb.h                 |    3 +-
>>  include/usb/musb_udc.h        |   54 +++
>>  10 files changed, 1451 insertions(+), 3 deletions(-)
>>  create mode 100644 drivers/usb/musb/musb_debug.h
>>  create mode 100644 drivers/usb/musb/musb_udc.c
>>  create mode 100644 drivers/usb/musb/omap3.c
>>  create mode 100644 drivers/usb/musb/omap3.h
>>  create mode 100644 include/usb/musb_udc.h
>>
> 
> <snip>
> ..
> ..
> 
>> +int musb_platform_init(void)
>> +{
>> +       int ret = -1;
>> +
>> +       if (platform_needs_initialization) {
>> +              u32 stdby;
>> +
>> +              if (twl4030_usb_ulpi_init()) {
>> +                      serial_printf("ERROR: %s Could not initialize
>> PHY\n",
>> +                              __PRETTY_FUNCTION__);
>> +                      goto end;
>> +              }
> 
> OMAP3EVM uses ISP1504 phy and so twl4030 related init is not required.
> Can we move this within #ifdef like,
> 
> #ifndef CONFIG_OMAP3_EVM
> +              if (twl4030_usb_ulpi_init()) {
> ...
> ...
> #endif
> 
> 
> -Ajay

I will include this in the next revision.
Will the omap3_evm need to add its own PHY initialization
code ?

  reply	other threads:[~2009-10-27 14:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27  5:18 [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Gupta, Ajay Kumar
2009-10-27 14:04 ` Tom [this message]
2009-10-28  8:46   ` Gupta, Ajay Kumar
  -- strict thread matches above, loose matches on Subject: below --
2009-09-28 16:37 [U-Boot] V2 of OMAP3 USB device Support Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-28 16:37   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-28 16:37     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-28 16:37       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-28 16:34 [U-Boot] V2 of OMAP3 USB device Support y at windriver.com
2009-09-28 16:34 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions y at windriver.com
2009-09-28 16:34   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup y at windriver.com
2009-09-28 16:34     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support y at windriver.com
2009-09-28 16:34       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support y at windriver.com
2009-09-04 20:12 [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-04 20:12 ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-04 20:12   ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-04 20:12     ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-05  0:25       ` Jean-Christophe PLAGNIOL-VILLARD
2009-09-06 13:35         ` Tom
2009-09-06 13:48           ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE6FDE4.3050807@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox