public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration
  2009-09-04 20:12       ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
@ 2009-09-04 20:12         ` Tom Rix
  2009-09-05  0:26           ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 7+ messages in thread
From: Tom Rix @ 2009-09-04 20:12 UTC (permalink / raw)
  To: u-boot

The primary console of beagle is the serial header.

A secondary console is to use the usbtty.  The user can set this
manually by doing

setenv stdout usbtty; setenv stdin usbtty; setenv stderr usbtty
saveenv

usbtty will be usable by accessing the /dev/ttyACM0 on a linux host.

Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
---
 include/configs/omap3_beagle.h |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index 61629f8..dc07934 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -98,6 +98,21 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* USB */
+#define CONFIG_MUSB_UDC			1
+#define CONFIG_USB_OMAP3		1
+#define CONFIG_TWL4030_USB		1
+
+/* USB device configuration */
+#define CONFIG_USB_DEVICE		1
+#define CONFIG_USB_TTY			1
+#define CONFIG_SYS_CONSOLE_IS_IN_ENV	1
+/* Change these to suit your needs */
+#define CONFIG_USBD_VENDORID		0x0451
+#define CONFIG_USBD_PRODUCTID		0x5678
+#define CONFIG_USBD_MANUFACTURER	"Texas Instruments"
+#define CONFIG_USBD_PRODUCT_NAME	"Beagle"
+
 /* commands to include */
 #include <config_cmd_default.h>
 
@@ -163,6 +178,7 @@
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"loadaddr=0x82000000\0" \
+	"usbtty=cdc_acm\0" \
 	"console=ttyS2,115200n8\0" \
 	"videomode=1024x768 at 60,vxres=1024,vyres=768\0" \
 	"videospec=omapfb:vram:2M,vram:4M\0" \
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration
  2009-09-04 20:12         ` [U-Boot] [PATCH 6/8] OMAP3 beagle " Tom Rix
@ 2009-09-05  0:26           ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 0 replies; 7+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-09-05  0:26 UTC (permalink / raw)
  To: u-boot

On 15:12 Fri 04 Sep     , Tom Rix wrote:
> The primary console of beagle is the serial header.
> 
> A secondary console is to use the usbtty.  The user can set this
> manually by doing
> 
> setenv stdout usbtty; setenv stdin usbtty; setenv stderr usbtty
> saveenv
> 
> usbtty will be usable by accessing the /dev/ttyACM0 on a linux host.
> 
> Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
> ---
>  include/configs/omap3_beagle.h |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Best Regards,
J.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration
  2009-09-28 16:35         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration y at windriver.com
@ 2009-09-28 16:35           ` y at windriver.com
  0 siblings, 0 replies; 7+ messages in thread
From: y at windriver.com @ 2009-09-28 16:35 UTC (permalink / raw)
  To: u-boot

From: Tom Rix <Tom.Rix@windriver.com>

The primary console of beagle is the serial header.

A secondary console is to use the usbtty.  The user can set this
manually by doing

setenv stdout usbtty; setenv stdin usbtty; setenv stderr usbtty
saveenv

usbtty will be usable by accessing the /dev/ttyACM0 on a linux host.

Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
---
 include/configs/omap3_beagle.h |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index 55eeb94..253cdba 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -98,6 +98,21 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* USB */
+#define CONFIG_MUSB_UDC			1
+#define CONFIG_USB_OMAP3		1
+#define CONFIG_TWL4030_USB		1
+
+/* USB device configuration */
+#define CONFIG_USB_DEVICE		1
+#define CONFIG_USB_TTY			1
+#define CONFIG_SYS_CONSOLE_IS_IN_ENV	1
+/* Change these to suit your needs */
+#define CONFIG_USBD_VENDORID		0x0451
+#define CONFIG_USBD_PRODUCTID		0x5678
+#define CONFIG_USBD_MANUFACTURER	"Texas Instruments"
+#define CONFIG_USBD_PRODUCT_NAME	"Beagle"
+
 /* commands to include */
 #include <config_cmd_default.h>
 
@@ -164,6 +179,7 @@
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"loadaddr=0x82000000\0" \
+	"usbtty=cdc_acm\0" \
 	"console=ttyS2,115200n8\0" \
 	"videomode=1024x768 at 60,vxres=1024,vyres=768\0" \
 	"videospec=omapfb:vram:2M,vram:4M\0" \
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration
  2009-09-28 16:37         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
@ 2009-09-28 16:37           ` Tom Rix
  0 siblings, 0 replies; 7+ messages in thread
From: Tom Rix @ 2009-09-28 16:37 UTC (permalink / raw)
  To: u-boot

The primary console of beagle is the serial header.

A secondary console is to use the usbtty.  The user can set this
manually by doing

setenv stdout usbtty; setenv stdin usbtty; setenv stderr usbtty
saveenv

usbtty will be usable by accessing the /dev/ttyACM0 on a linux host.

Signed-off-by: Tom Rix <Tom.Rix@windriver.com>
---
 include/configs/omap3_beagle.h |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
index 55eeb94..253cdba 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -98,6 +98,21 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* USB */
+#define CONFIG_MUSB_UDC			1
+#define CONFIG_USB_OMAP3		1
+#define CONFIG_TWL4030_USB		1
+
+/* USB device configuration */
+#define CONFIG_USB_DEVICE		1
+#define CONFIG_USB_TTY			1
+#define CONFIG_SYS_CONSOLE_IS_IN_ENV	1
+/* Change these to suit your needs */
+#define CONFIG_USBD_VENDORID		0x0451
+#define CONFIG_USBD_PRODUCTID		0x5678
+#define CONFIG_USBD_MANUFACTURER	"Texas Instruments"
+#define CONFIG_USBD_PRODUCT_NAME	"Beagle"
+
 /* commands to include */
 #include <config_cmd_default.h>
 
@@ -164,6 +179,7 @@
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"loadaddr=0x82000000\0" \
+	"usbtty=cdc_acm\0" \
 	"console=ttyS2,115200n8\0" \
 	"videomode=1024x768 at 60,vxres=1024,vyres=768\0" \
 	"videospec=omapfb:vram:2M,vram:4M\0" \
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration
       [not found] <19F8576C6E063C45BE387C64729E73940436E5F620@dbde02.ent.ti.com>
@ 2009-10-27  5:25 ` Gupta, Ajay Kumar
  2009-10-27 14:07   ` Tom
  0 siblings, 1 reply; 7+ messages in thread
From: Gupta, Ajay Kumar @ 2009-10-27  5:25 UTC (permalink / raw)
  To: u-boot

Tom,
> From: Tom Rix <Tom.Rix <at> windriver.com>
> Subject: [PATCH 6/8] OMAP3 beagle Add usbtty configuration
> Newsgroups: gmane.comp.boot-loaders.u-boot
> Date: 2009-09-28 16:37:27 GMT (4 weeks, 12 hours and 41 minutes ago)
> 
> The primary console of beagle is the serial header.
> 
> A secondary console is to use the usbtty.  The user can set this
> manually by doing
> 
> setenv stdout usbtty; setenv stdin usbtty; setenv stderr usbtty
> saveenv
> 
> usbtty will be usable by accessing the /dev/ttyACM0 on a linux host.
> 
> Signed-off-by: Tom Rix <Tom.Rix <at> windriver.com>
> ---
>  include/configs/omap3_beagle.h |   16 ++++++++++++++++
>  1 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/omap3_beagle.h
> b/include/configs/omap3_beagle.h
> index 55eeb94..253cdba 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -98,6 +98,21 @@
>  #define CONFIG_OMAP3_MMC		1
>  #define CONFIG_DOS_PARTITION		1
> 
> +/* USB */
> +#define CONFIG_MUSB_UDC			1
> +#define CONFIG_USB_OMAP3		1
> +#define CONFIG_TWL4030_USB		1
> +
> +/* USB device configuration */
> +#define CONFIG_USB_DEVICE		1
> +#define CONFIG_USB_TTY			1
> +#define CONFIG_SYS_CONSOLE_IS_IN_ENV	1
> +/* Change these to suit your needs */
> +#define CONFIG_USBD_VENDORID		0x0451
> +#define CONFIG_USBD_PRODUCTID		0x5678
> +#define CONFIG_USBD_MANUFACTURER	"Texas Instruments"
> +#define CONFIG_USBD_PRODUCT_NAME	"Beagle"
> +

We can either define CONFIG_MUSB_UDC or CONFIG_MUSB_HCD (host support), so I think it's better to move host and device specific definitions within
CONFIG_MUSB_UDC or CONFIG_MUSB_HCD.

#ifdef CONFIG_USB_OMAP3

#ifdef  CONFIG_MUSB_HCD
<here define all host specific definitions>
#endif

#ifdef  CONFIG_MUSB_UDC
<here define all device specific definitions>
#endif

#endif /* CONFIG_USB_OMAP3 */

This change would make it easier to test Host or device functionalities.

-Ajay

>  /* commands to include */
>  #include <config_cmd_default.h>
> 
> @@ -164,6 +179,7 @@
> 
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>  	"loadaddr=0x82000000\0" \
> +	"usbtty=cdc_acm\0" \
>  	"console=ttyS2,115200n8\0" \
>  	"videomode=1024x768 <at> 60,vxres=1024,vyres=768\0" \
>  	"videospec=omapfb:vram:2M,vram:4M\0" \
> --
> 1.6.0.6

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration
  2009-10-27  5:25 ` [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration Gupta, Ajay Kumar
@ 2009-10-27 14:07   ` Tom
  2009-10-28  8:52     ` Gupta, Ajay Kumar
  0 siblings, 1 reply; 7+ messages in thread
From: Tom @ 2009-10-27 14:07 UTC (permalink / raw)
  To: u-boot

Gupta, Ajay Kumar wrote:
> Tom,
>> From: Tom Rix <Tom.Rix <at> windriver.com>
>> Subject: [PATCH 6/8] OMAP3 beagle Add usbtty configuration
>> Newsgroups: gmane.comp.boot-loaders.u-boot
>> Date: 2009-09-28 16:37:27 GMT (4 weeks, 12 hours and 41 minutes ago)
>>
>> The primary console of beagle is the serial header.
>>
>> A secondary console is to use the usbtty.  The user can set this
>> manually by doing
>>
>> setenv stdout usbtty; setenv stdin usbtty; setenv stderr usbtty
>> saveenv
>>
>> usbtty will be usable by accessing the /dev/ttyACM0 on a linux host.
>>
>> Signed-off-by: Tom Rix <Tom.Rix <at> windriver.com>
>> ---
>>  include/configs/omap3_beagle.h |   16 ++++++++++++++++
>>  1 files changed, 16 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/configs/omap3_beagle.h
>> b/include/configs/omap3_beagle.h
>> index 55eeb94..253cdba 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -98,6 +98,21 @@
>>  #define CONFIG_OMAP3_MMC		1
>>  #define CONFIG_DOS_PARTITION		1
>>
>> +/* USB */
>> +#define CONFIG_MUSB_UDC			1
>> +#define CONFIG_USB_OMAP3		1
>> +#define CONFIG_TWL4030_USB		1
>> +
>> +/* USB device configuration */
>> +#define CONFIG_USB_DEVICE		1
>> +#define CONFIG_USB_TTY			1
>> +#define CONFIG_SYS_CONSOLE_IS_IN_ENV	1
>> +/* Change these to suit your needs */
>> +#define CONFIG_USBD_VENDORID		0x0451
>> +#define CONFIG_USBD_PRODUCTID		0x5678
>> +#define CONFIG_USBD_MANUFACTURER	"Texas Instruments"
>> +#define CONFIG_USBD_PRODUCT_NAME	"Beagle"
>> +
> 
> We can either define CONFIG_MUSB_UDC or CONFIG_MUSB_HCD (host support), so I think it's better to move host and device specific definitions within
> CONFIG_MUSB_UDC or CONFIG_MUSB_HCD.
> 
> #ifdef CONFIG_USB_OMAP3
> 
> #ifdef  CONFIG_MUSB_HCD
> <here define all host specific definitions>
> #endif
> 
> #ifdef  CONFIG_MUSB_UDC
> <here define all device specific definitions>
> #endif
> 
> #endif /* CONFIG_USB_OMAP3 */
> 
> This change would make it easier to test Host or device functionalities.
> 
> -Ajay

I am not adding host support.
Tom

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration
  2009-10-27 14:07   ` Tom
@ 2009-10-28  8:52     ` Gupta, Ajay Kumar
  0 siblings, 0 replies; 7+ messages in thread
From: Gupta, Ajay Kumar @ 2009-10-28  8:52 UTC (permalink / raw)
  To: u-boot

Tom,
> >
> > We can either define CONFIG_MUSB_UDC or CONFIG_MUSB_HCD (host support),
> so I think it's better to move host and device specific definitions within
> > CONFIG_MUSB_UDC or CONFIG_MUSB_HCD.
> >
> > #ifdef CONFIG_USB_OMAP3
> >
> > #ifdef  CONFIG_MUSB_HCD
> > <here define all host specific definitions>
> > #endif
> >
> > #ifdef  CONFIG_MUSB_UDC
> > <here define all device specific definitions>
> > #endif
> >
> > #endif /* CONFIG_USB_OMAP3 */
> >
> > This change would make it easier to test Host or device functionalities.
> >
> > -Ajay
> 
> I am not adding host support.

Host side controller driver is already available (musb_hcd.c) and can be used by any omap3 platforms.

So I think we can add host config also for all the omap3 platforms which anyways doesn't break device functionality.

I would be submitting USB config patch for omap3_evm by today.

-Ajay  

> Tom

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2009-10-28  8:52 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <19F8576C6E063C45BE387C64729E73940436E5F620@dbde02.ent.ti.com>
2009-10-27  5:25 ` [U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration Gupta, Ajay Kumar
2009-10-27 14:07   ` Tom
2009-10-28  8:52     ` Gupta, Ajay Kumar
2009-09-28 16:37 [U-Boot] V2 of OMAP3 USB device Support Tom Rix
2009-09-28 16:37 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-28 16:37   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-28 16:37     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-28 16:37       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-28 16:37         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-09-28 16:37           ` [U-Boot] [PATCH 6/8] OMAP3 beagle " Tom Rix
  -- strict thread matches above, loose matches on Subject: below --
2009-09-28 16:34 [U-Boot] V2 of OMAP3 USB device Support y at windriver.com
2009-09-28 16:34 ` [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions y at windriver.com
2009-09-28 16:34   ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup y at windriver.com
2009-09-28 16:34     ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support y at windriver.com
2009-09-28 16:34       ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support y at windriver.com
2009-09-28 16:35         ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration y at windriver.com
2009-09-28 16:35           ` [U-Boot] [PATCH 6/8] OMAP3 beagle " y at windriver.com
2009-09-04 20:12 [U-Boot] [PATCH 1/8] USB Consolidate descriptor definitions Tom Rix
2009-09-04 20:12 ` [U-Boot] [PATCH 2/8] USB add macros for debugging usb device setup Tom Rix
2009-09-04 20:12   ` [U-Boot] [PATCH 3/8] TWL4030 Add usb PHY support Tom Rix
2009-09-04 20:12     ` [U-Boot] [PATCH 4/8] OMAP3 Add usb device support Tom Rix
2009-09-04 20:12       ` [U-Boot] [PATCH 5/8] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-09-04 20:12         ` [U-Boot] [PATCH 6/8] OMAP3 beagle " Tom Rix
2009-09-05  0:26           ` Jean-Christophe PLAGNIOL-VILLARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox