From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2
Date: Thu, 29 Oct 2009 10:21:23 -0500 [thread overview]
Message-ID: <4AE9B2F3.9060305@windriver.com> (raw)
In-Reply-To: <20091029145629.14C7019F73@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Tom,
>
> In message <4AE99F40.4000107@windriver.com> you wrote:
>>> By the way, the AT91RM9200.h. has hundreds of style problems.
>>> This requires a complete revision of the AT91RM9200.h.
>>> I can try this, but will take a while and I can't test other
>>> RM9200 boards.
>> Please limit your changes to what you can test.
>> Tom
>
> Pure coding style changes are easy to verify - they should lead to
> identical (except for the time stamps) images.
>
> Also, board maintainers can and should be challenged to test such
> patches.
>
> Please don't stop improving the code just because others need to help
> with the testing.
I was thinking that this would be converting from #define offsets to
structures. It can be easy to get these wrong. Without testing
as-you-go these types of bugs can be difficult to resolve.
Tom
>
> Best regards,
>
> Wolfgang Denk
>
next prev parent reply other threads:[~2009-10-29 15:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 8:38 [U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2 Jens Scharsig
2009-10-27 11:02 ` Wolfgang Denk
2009-10-27 12:38 ` Jens Scharsig
2009-10-27 18:35 ` Wolfgang Denk
2009-10-28 10:10 ` Jens Scharsig
2009-10-28 14:35 ` Wolfgang Denk
2009-10-29 7:40 ` Jens Scharsig
2009-10-29 10:47 ` Wolfgang Denk
2009-10-29 13:41 ` Jens Scharsig
2009-10-29 13:57 ` Tom
2009-10-29 14:56 ` Wolfgang Denk
2009-10-29 15:21 ` Tom [this message]
2009-10-30 8:30 ` Wolfgang Denk
2009-10-30 9:10 ` Jens Scharsig
2009-10-27 21:27 ` Scott Wood
2009-10-27 11:44 ` Wolfgang Denk
2009-10-27 15:26 ` Jens Scharsig
2009-10-27 19:04 ` Wolfgang Denk
2009-10-28 14:37 ` [U-Boot] [PATCH V2] " Jens Scharsig
2009-10-28 14:42 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE9B2F3.9060305@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox