From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Thu, 29 Oct 2009 10:21:23 -0500
Subject: [U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2
In-Reply-To: <20091029145629.14C7019F73@gemini.denx.de>
References: <4AE6B186.9030301@bus-elektronik.de>
	<20091027110234.A0787E916D5@gemini.denx.de>
	<hc6pk5$tvs$1@ger.gmane.org>
	<20091027183506.20010E916D5@gemini.denx.de>
	<4AE81893.30506@bus-elektronik.de>
	<20091028143524.B7AD7E916D6@gemini.denx.de>
	<4AE946E7.4050404@bus-elektronik.de>
	<20091029104729.7958119F73@gemini.denx.de>
	<4AE99BA5.3090007@bus-elektronik.de>
	<4AE99F40.4000107@windriver.com>
	<20091029145629.14C7019F73@gemini.denx.de>
Message-ID: <4AE9B2F3.9060305@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear Tom,
> 
> In message <4AE99F40.4000107@windriver.com> you wrote:
>>> By the way, the AT91RM9200.h. has hundreds of style problems.
>>> This requires a complete revision of the AT91RM9200.h. 
>>> I can try this, but will take a while and I can't test other
>>> RM9200 boards.
>> Please limit your changes to what you can test.
>> Tom
> 
> Pure coding style changes are easy to verify - they should lead to
> identical (except for the time stamps) images.
> 
> Also, board maintainers can and should be challenged to test such
> patches.
> 
> Please don't stop improving the code just because others need to help
> with the testing.

I was thinking that this would be converting from #define offsets to
structures. It can be easy to get these wrong.  Without testing 
as-you-go these types of bugs can be difficult to resolve.

Tom

> 
> Best regards,
> 
> Wolfgang Denk
>