From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM S3C2410 add new board GEC2410
Date: Thu, 29 Oct 2009 22:18:17 -0500 [thread overview]
Message-ID: <4AEA5AF9.7060008@xes-inc.com> (raw)
In-Reply-To: <1f3430fb0910291844o698bf74m48f3d176b4d5047@mail.gmail.com>
> 2009/10/29 Hui.Tang <zetalabs@gmail.com>:
>> This patch add a S3C2410-based new board GEC2410.
>> Signed-off-by: Hui.Tang <zetalabs@gmail.com>
>> ---
>> Makefile | 7 +
>> board/gec/gec2410/Makefile | 51 ++++
>> board/gec/gec2410/config.mk | 32 +++
>> board/gec/gec2410/flash.c | 433 +++++++++++++++++++++++++++++++++
>> board/gec/gec2410/gec2410.c | 147 +++++++++++
>> board/gec/gec2410/lowlevel_init.S | 169 +++++++++++++
>> board/gec/gec2410/u-boot-nand.lds | 61 +++++
>> cpu/arm920t/s3c24x0/timer.c | 1 +
>> cpu/arm920t/start.S | 36 +++
>> drivers/mtd/nand/s3c2410_nand.c | 46 +++-
>> drivers/net/cs8900.c | 2 +-
>> include/configs/gec2410.h | 288 ++++++++++++++++++++++
>> nand_spl/board/gec/gec2410/Makefile | 102 ++++++++
>> nand_spl/board/gec/gec2410/config.mk | 40 +++
>> nand_spl/board/gec/gec2410/u-boot.lds | 60 +++++
>> 15 files changed, 1469 insertions(+), 6 deletions(-)
>> create mode 100644 board/gec/gec2410/Makefile
>> create mode 100644 board/gec/gec2410/config.mk
>> create mode 100644 board/gec/gec2410/flash.c
>> create mode 100644 board/gec/gec2410/gec2410.c
>> create mode 100644 board/gec/gec2410/lowlevel_init.S
>> create mode 100644 board/gec/gec2410/u-boot-nand.lds
>> create mode 100644 include/configs/gec2410.h
>> create mode 100644 nand_spl/board/gec/gec2410/Makefile
>> create mode 100644 nand_spl/board/gec/gec2410/config.mk
>> create mode 100644 nand_spl/board/gec/gec2410/u-boot.lds
>>
>
> thanks for your patch.
>
> First, please do checkpatch and fix the style problems.
> (total: 20 errors, 106 warnings, 1614 lines checked)
> Second, please separate your patch (board, cpu, soc, spl, etc..)
> Third, please fix the copyright. I couldn't find your name.
> And then, we will review your patch.
You should also add an entry to MAINTAINERS and MAKEALL when you
resubmit your board support patch.
Best,
Peter
prev parent reply other threads:[~2009-10-30 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 13:05 [U-Boot] [PATCH] ARM S3C2410 add new board GEC2410 Hui.Tang
2009-10-29 23:58 ` Scott Wood
2009-10-30 1:44 ` Minkyu Kang
2009-10-30 3:18 ` Peter Tyser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEA5AF9.7060008@xes-inc.com \
--to=ptyser@xes-inc.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox