From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Sun, 01 Nov 2009 11:09:25 -0600
Subject: [U-Boot] [PATCH] Add I2C multibus support for OMAP2/3 boards
In-Reply-To: <4AED8256.1090208@windriver.com>
References: <1257040373-1569-1-git-send-email-Tom.Rix@windriver.com>	<1257040373-1569-2-git-send-email-Tom.Rix@windriver.com>	<4AED45A1.1090703@googlemail.com>
	<4AED8256.1090208@windriver.com>
Message-ID: <4AEDC0C5.2040905@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Tom wrote:
> Dirk Behme wrote:
>> Tom Rix wrote:
>>> From: Syed Mohammed Khasim <khasim@ti.com>
>>>
>>> This was cherry-picked from
>>>
>>> repo: http://www.beagleboard.org/u-boot-arm.git
>>> commit: 52eddcd07c2e7ad61d15bab2cf2d0d21466eaca2
>>>
>>> In addition to adding multibus support, this patch
>>> also cleans up the register access.  The register
>>> access has been changed from #defines to a structure.
>> Have you looked at my proposal I sent some hours before your patch?
> 
> Sorry.  I did not.
> Not surprisingly it looks similar.
> 
> The formatting changes you mentioned were part of the original
> cherry-picked commit.  I tried to leave as much of the original
> commit intact as possible.  I ran but ignored the output of
> checkpatch.. The biggest complaint it has is with 80 char lines.
> 
> I looked over your patch.
> It looks like an improvement to mine.
> 
> I'm all for dropping mine and using yours.
> I will run test yours.
> 
> Do you have a zippy board that you can use to test the 2nd bus ?
> 
Dirk,

Some feedback.

No regressions on MAKEALL arm

I ran tested your patch Zoom1 and Beagle.
Default i2c looks good.
I did not test the multibus support.

Looks good, please officially submit your patch.

Tom

> Tom
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot