public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 3/5] CAN device driver for the SJA1000
Date: Mon, 02 Nov 2009 21:20:40 +0100	[thread overview]
Message-ID: <4AEF3F18.6000103@grandegger.com> (raw)
In-Reply-To: <200911021522.16256.matthias.fuchs@esd.eu>

Matthias Fuchs wrote:
> Hi Wolfgang,
> 
> of course I can think of situations where some simple CAN mechanism
> might be helpful (e.g. simple hardware testing). 
> 
> But do we really need this inside a bootloader? Surely not
> for a production build. But please keep on hacking!
> 
> On Monday 02 November 2009 13:50, Wolfgang Grandegger wrote:
>> Matthias Fuchs wrote:
>>> Hi Wolfgang,
>>>
>>> this patch conflicts with my simple SJA header posted some days ago
>>>
>>> http://lists.denx.de/pipermail/u-boot/2009-October/063097.html
>>>
>>> together with a fix for two of our boards - which has not much
>>> to do with CAN. WD asked me to use a C struct to access the SJA1000. 
>>>
>>> http://lists.denx.de/pipermail/u-boot/2009-October/062902.html
>>>
>>> So where does this bring us? Either we want to use C structs for everything
>>> or decide it from patch to patch :-(
>> Then it should be changed, of course. This patch is far from being
>> accepted and for the moment it's an implementation detail. I'm
>> especially interested to hear if such a generic CAN interface would
>> serve your purposes as well, as you require access to the SJA1000 somehow.
> 
> I just need to bit bang around in the OCR register. So no need for a full blown
> and flash consuming CAN implementation. Of course I could life with your
> register access style. Especially because it makes the code more common with
> Socket-CAN files which prevents us from rewriting fully functional code ;-)

Well, I think Wolfgang will tell me to use structs sooner than later.

Wolfgang.

  reply	other threads:[~2009-11-02 20:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-01 11:33 [U-Boot] [RFC 0/5] CAN framework for U-Boot Wolfgang Grandegger
2009-11-01 11:33 ` [U-Boot] [RFC 1/5] CAN interface library Wolfgang Grandegger
2009-11-01 11:33   ` [U-Boot] [RFC 2/5] CAN device test command Wolfgang Grandegger
2009-11-01 11:33     ` [U-Boot] [RFC 3/5] CAN device driver for the SJA1000 Wolfgang Grandegger
2009-11-01 11:33       ` [U-Boot] [RFC 4/5] CAN device driver for the Intel 82527 Wolfgang Grandegger
2009-11-01 11:33         ` [U-Boot] [RFC 5/5] CAN interface support for the TQM855L module Wolfgang Grandegger
2009-11-02 12:02       ` [U-Boot] [RFC 3/5] CAN device driver for the SJA1000 Matthias Fuchs
2009-11-02 12:50         ` Wolfgang Grandegger
2009-11-02 14:22           ` Matthias Fuchs
2009-11-02 20:20             ` Wolfgang Grandegger [this message]
2009-11-05 20:28               ` Wolfgang Denk
2009-11-01 14:45     ` [U-Boot] [RFC 2/5] CAN device test command Mike Frysinger
2009-11-01 16:24       ` Wolfgang Grandegger
2009-11-01 18:07         ` Mike Frysinger
2009-11-01 14:36   ` [U-Boot] [RFC 1/5] CAN interface library Mike Frysinger
2009-11-01 16:16     ` Wolfgang Grandegger
2009-11-01 18:05       ` Mike Frysinger
2009-11-01 22:00         ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AEF3F18.6000103@grandegger.com \
    --to=wg@grandegger.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox