public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] ARM Add New Board GEC2410
Date: Wed, 04 Nov 2009 15:56:32 -0800	[thread overview]
Message-ID: <4AF214B0.2090403@gmail.com> (raw)
In-Reply-To: <1257324600-19493-1-git-send-email-zetalabs@gmail.com>

Hui.Tang wrote:
> Fix cs8900 dev->priv not init issue, do it as Ben Warren's suggestion.
>
> checkpatch.pl result is
>
> total: 0 errors, 0 warnings, 19 lines checked
>
> 0004-Fix-dev-priv-not-init-issue.patch has no obvious style problems and is ready for submission.
>
> =========================================================
>   
This stuff should go below the '---' line so that it doesn't become part 
of the changelog.
Also, this patch has nothing to do with 'ARM Add New Board GEC2410'.  It 
should be a stand-alone patch, not part of your board submission.  
Please use a more appropriate title.
> Signed-off-by: Hui.Tang <zetalabs@gmail.com>
> ---
>  drivers/net/cs8900.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c
> index 587f7f6..a9d1f22 100644
> --- a/drivers/net/cs8900.c
> +++ b/drivers/net/cs8900.c
> @@ -321,15 +321,16 @@ int cs8900_initialize(u8 dev_num, int base_addr)
>  	memset(priv, 0, sizeof(*priv));
>  	priv->regs = (struct cs8900_regs *)base_addr;
>  
> -	/* Load MAC address from EEPROM */
> -	cs8900_get_enetaddr(dev);
> -
>  	dev->iobase = base_addr;
>  	dev->priv = priv;
>  	dev->init = cs8900_init;
>  	dev->halt = cs8900_halt;
>  	dev->send = cs8900_send;
>  	dev->recv = cs8900_recv;
> +
> +	/* Load MAC address from EEPROM */
> +	cs8900_get_enetaddr(dev);
> +
>  	sprintf(dev->name, "%s-%hu", CS8900_DRIVERNAME, dev_num);
>  
>  	eth_register(dev);
>   
The content looks fine, but the patch metadata needs to be re-done.

regards,
Ben

      reply	other threads:[~2009-11-04 23:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04  8:50 [U-Boot] [PATCH 4/4] ARM Add New Board GEC2410 Hui.Tang
2009-11-04 23:56 ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF214B0.2090403@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox