From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dirk Behme <dirk.behme@googlemail.com>
Date: Thu, 05 Nov 2009 07:35:26 +0100
Subject: [U-Boot] [PATCH] Add I2C multibus support for OMAP2/3 boards
In-Reply-To: <4AF26FE8.8020606@denx.de>
References: <1257040373-1569-1-git-send-email-Tom.Rix@windriver.com>
	<1257040373-1569-2-git-send-email-Tom.Rix@windriver.com>
	<4AED45A1.1090703@googlemail.com> <4AEE8A1A.8000607@denx.de>
	<4AEF33E6.2030104@googlemail.com> <4AF26FE8.8020606@denx.de>
Message-ID: <4AF2722E.3090901@googlemail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Heiko,

Heiko Schocher wrote:
> Hello Dirk,
> 
> Dirk Behme wrote:
>> Heiko Schocher wrote:
>>> Dirk Behme wrote:
> [...]
>>>> While all above are only style questions, what's about the main
>>>> functionality topic:
>>>>
>>>> Do we have to call i2c_init() for bus 1 and 2 if switching to it? If
>>>> yes, who does it? For bus 0 it's already in the code. I'd like that the
>>>> user doesn't have to care about it. Therefore, I added
>>> I solved this in the multibus_v2 branch, see:
>>>
>>> http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=shortlog;h=refs/heads/multibus_v2
>>>
>> Looks like we have to merge that with what is in this patch somehow.
>> What are your plans with that branch? Is it intended to go into
>> mainline, soon?
> 
> I have to do some more work, before this is ready to go in mainline...
> 
>> It seems to me that multibus_v2 and this patch are somehow orthogonal
>> (but yes, they will need some merging).
> 
> Yep, I hold the multibus_v2 branch in sync with mainline.
> 
>> Regarding omap24xx_i2c.c, multibus_v2 seems to deal mainly with the API
>> stuff
>>
>> http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=blobdiff;f=drivers/i2c/omap24xx_i2c.c;h=993b995d34a298d07fbd11bce23f2d0cfdebb40f;hp=1a4c8c9ad2701b550fc1ad0ab2a9fde741902080;hb=899dbf9fbd089a9e8133026be3817e0116f44390;hpb=24d3d6307e1e5d5cddddee399a15e70ef9da8818
> 
> Yep, I adapt this driver only for working with this new API.
> 
>> while the main part of this patch is to replace all hard coded registers
>> by the ability to switch to an other bus.
>>
>> I will send an updated patch with fixing at least the review comments,
>> soon.

Hmm, do you like to push

http://lists.denx.de/pipermail/u-boot/2009-November/063658.html

to I2C git main branch then?

Or are you fine that we push it to u-boot-ti?

Or?

Thanks

Dirk