From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Date: Thu, 05 Nov 2009 14:39:49 -0600 Subject: [U-Boot] [PATCH 2/2] ARM: fix build error with gcc-4.4.2 about inline function declared weak In-Reply-To: <20091105201959.43CD93F6EC@gemini.denx.de> References: <1257292804-10612-1-git-send-email-Tom.Rix@windriver.com> <1257292804-10612-2-git-send-email-Tom.Rix@windriver.com> <1257292804-10612-3-git-send-email-Tom.Rix@windriver.com> <20091105201959.43CD93F6EC@gemini.denx.de> Message-ID: <4AF33815.4030101@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Tom Rix, > > In message <1257292804-10612-3-git-send-email-Tom.Rix@windriver.com> you wrote: >> From: Abdoulaye Walsimou Gaye >> >> This patch fix build error with gcc-4.4.2 about inline function >> declared weak, see below: >> board.c:96: error: inline function 'coloured_LED_init' cannot be declared weak >> board.c:98: error: inline function 'red_LED_on' cannot be declared weak >> board.c:100: error: inline function 'red_LED_off' cannot be declared weak >> board.c:102: error: inline function 'green_LED_on' cannot be declared weak >> board.c:104: error: inline function 'green_LED_off' cannot be declared weak >> board.c:106: error: inline function 'yellow_LED_on' cannot be declared weak >> board.c:108: error: inline function 'yellow_LED_off' cannot be declared weak >> board.c:110: error: inline function 'blue_LED_on' cannot be declared weak >> board.c:112: error: inline function 'blue_LED_off' cannot be declared weak >> make[1]: *** [board.o] Error 1 >> >> Signed-off-by: Abdoulaye Walsimou Gaye > > What is this? Are you sure this patch is properly attributed? Was > Abdoulaye Walsimou Gaye really the first to submit this patch? > > Best regards, > > Wolfgang Denk > Would you like the older one ? As you said, they looked the same. Tom