From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix cs8900 dev->priv not init issue
Date: Mon, 09 Nov 2009 10:41:56 -0800 [thread overview]
Message-ID: <4AF86274.1010708@gmail.com> (raw)
In-Reply-To: <1257386324-23216-1-git-send-email-zetalabs@gmail.com>
Hui.Tang wrote:
> Fix cs8900 dev->priv not init issue, do it as Ben Warren's suggestion.
>
> Signed-off-by: Hui.Tang <zetalabs@gmail.com>
> ---
> drivers/net/cs8900.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c
> index 587f7f6..a9d1f22 100644
> --- a/drivers/net/cs8900.c
> +++ b/drivers/net/cs8900.c
> @@ -321,15 +321,16 @@ int cs8900_initialize(u8 dev_num, int base_addr)
> memset(priv, 0, sizeof(*priv));
> priv->regs = (struct cs8900_regs *)base_addr;
>
> - /* Load MAC address from EEPROM */
> - cs8900_get_enetaddr(dev);
> -
> dev->iobase = base_addr;
> dev->priv = priv;
> dev->init = cs8900_init;
> dev->halt = cs8900_halt;
> dev->send = cs8900_send;
> dev->recv = cs8900_recv;
> +
> + /* Load MAC address from EEPROM */
> + cs8900_get_enetaddr(dev);
> +
> sprintf(dev->name, "%s-%hu", CS8900_DRIVERNAME, dev_num);
>
> eth_register(dev);
>
Applied to net repo with minor commit message editing.
thanks,
Ben
prev parent reply other threads:[~2009-11-09 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 1:58 [U-Boot] [PATCH] Fix cs8900 dev->priv not init issue Hui.Tang
2009-11-09 18:41 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF86274.1010708@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox