From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.aribaud@free.fr>
Date: Mon, 09 Nov 2009 19:57:28 +0100
Subject: [U-Boot] Best way of making some drivers common across kirkwood
 and orion5x SoCs?
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E202F45D49DE@SC-VEXCH1.marvell.com>
References: <73173D32E9439E4ABB5151606C3E19E202F45D49DE@SC-VEXCH1.marvell.com>
Message-ID: <4AF86618.9060400@free.fr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi PRafulla,

Prafulla Wadaskar a ?crit :

 > 1. For SOC support Orion should be implemented similar to Kirkwood
 > (you agreed on this)

I still do. :)

 > 2. For common drivers for (ex: kirkwood_egiga.c) the common code must
 > be abstracted to egiga_core.c and architecture specific code must be
 > supported through kirkwood_egiga.c/h and orion_egiga.c/h, this way it
 > would make it more clean and structured.

Agreed.

 > What is your opinion with #2 suggestion?

Sounds fine! I'll start submitting patches for both common drivers and 
orion support based on this proposal.

Regarding the arch-specific parts of current driver code, should they 
end up in cpu/arm926ejs/{kirkwood,orion5x} or stay in drivers/*? I tend 
like cpu/arm926ejs/* better as it puts everything arch-specific in a 
single place.

Amicalement,
-- 
Albert.