From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Mon, 09 Nov 2009 13:41:03 -0800
Subject: [U-Boot] [PATCH] smc91111_eeprom: fix compile warning
In-Reply-To: <200911091636.54896.vapier@gentoo.org>
References: <1257801598-30823-1-git-send-email-biggerbadderben@gmail.com>
	<200911091636.54896.vapier@gentoo.org>
Message-ID: <4AF88C6F.20602@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Mike Frysinger wrote:
> On Monday 09 November 2009 16:19:58 Ben Warren wrote:
>   
>> smc91111_eeprom.c:278: warning: suggest parentheses around + or - in
>>  operand
>>  smc91111_eeprom.c:281: warning: suggest parentheses around + or -
>>  in operand
>>
>>  	for (i = 0; i < 5; i++) {
>> -		printf ("%02x:", SMC_inb (dev, ADDR0_REG + i));
>> +		printf ("%02x:", SMC_inb (dev, (ADDR0_REG + i)));
>>  	}
>>     
>
> erm, this says to me that the SMC inb macro is broken.  it should be using 
> paren when expanding the second argument.  so lets fix that instead.
> -mike
>   

Yeah, I see where it is:

#define SMC_inb(a,p)  ({ \
	unsigned int __p = (unsigned int)((a)->iobase + (p<<1)); \
	unsigned int __v = *(volatile unsigned short *)((__p) & ~2); \
	if (__p & 2) __v >>= 8; \
	else __v &= 0xff; \
	__v; })


(p<<1) --> ((p)<<1)

Thanks for pointing this out.  Patch coming up.

regards,
Ben