public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot] [PATCH] [1/2] [v1.2] mxc_fec: fix some erroneous PHY accesses.
Date: Mon, 09 Nov 2009 22:52:26 -0800	[thread overview]
Message-ID: <4AF90DAA.6070807@gmail.com> (raw)
In-Reply-To: <eedb5540910290018t33b76526s1332ff56717025c9@mail.gmail.com>

Javier,

javier Martin wrote:
> This patch fixes erroneous access to the ethernet PHY which broke the driver.
> 1. Selector field in the auto-negotiation register must be 0x00001 for
> using 802.3, not 0x00000 which is reseved.
> 2. Access to the PHY address specified by CONFIG_FEC_MXC_PHYADDR, not
> 0x0 fixed address.
>
> This has been tested in i.MX27 Litekit board and eldk-4.2 toolchains.
>
> Now using proper defines for auto-negotiation register.
>
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
> --
Applied to net repo.

thanks,
Ben

      parent reply	other threads:[~2009-11-10  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29  7:18 [U-Boot] [u-boot] [PATCH] [1/2] [v1.2] mxc_fec: fix some erroneous PHY accesses javier Martin
2009-11-05 14:05 ` javier Martin
2009-11-10  6:52 ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF90DAA.6070807@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox