public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3: add CM-T35 board
Date: Wed, 11 Nov 2009 08:24:13 -0600	[thread overview]
Message-ID: <4AFAC90D.2020902@windriver.com> (raw)
In-Reply-To: <1257949086.30532.13.camel@ptyser-laptop>

Peter Tyser wrote:
> <snip>
> 
>>>>>> --- a/Makefile
>>>>>> +++ b/Makefile
>>>>>> @@ -3168,6 +3168,9 @@ omap3_zoom1_config :    unconfig
>>>>>>  omap3_zoom2_config : unconfig
>>>>>>       @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
>>>>>>
>>>>>> +omap3_cm-t35_config :        unconfig
>>>>>> +     @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 cm-t35 NULL omap3
>>>>>> +
>>> I'd title your _config rule the same as your board name, ie drop the
>>> omap3_ prefix above.  And the above list should be alphabetically
>>> sorted.
>> I'd prefer to keep the 'omap3_' prefix to stay inline with other omap3 boards.
> 
> Just because the other omap3_ board are wrong doesn't mean your board
> should be too:)  This same question was discussed for the devkit8000:
> http://www.mail-archive.com/u-boot at lists.denx.de/msg21317.html
> 

Please drop the omap3_ prefix.
New boards are following the standard convention.

Tom

  reply	other threads:[~2009-11-11 14:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11  8:03 [U-Boot] [PATCH] omap3: add CM-T35 board Mike Rapoport
2009-11-11 13:01 ` Paulraj, Sandeep
2009-11-11 13:41   ` Mike Rapoport
2009-11-11 13:58     ` Peter Tyser
2009-11-11 14:07       ` Mike Rapoport
2009-11-11 14:18         ` Peter Tyser
2009-11-11 14:24           ` Tom [this message]
2009-11-11 14:56             ` Mike Rapoport
2009-11-11 21:35         ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2010-11-23  7:29 [U-Boot] [PATCH] OMAP3: " Mike Rapoport
2010-11-24  2:58 ` Nishanth Menon
2010-11-25 16:29   ` Paulraj, Sandeep
2010-11-28  7:56   ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFAC90D.2020902@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox