From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Rapoport <mike@compulab.co.il>
Date: Wed, 11 Nov 2009 16:56:13 +0200
Subject: [U-Boot] [PATCH] omap3: add CM-T35 board
In-Reply-To: <4AFAC90D.2020902@windriver.com>
References: <1257926592-14782-4-git-send-email-mike@compulab.co.il>	<0554BEF07D437848AF01B9C9B5F0BC5D93EBF482@dlee01.ent.ti.com>	<4AFABEF0.4040404@compulab.co.il>	<1257947893.30532.8.camel@ptyser-laptop>	<4AFAC505.5000003@compulab.co.il>
	<1257949086.30532.13.camel@ptyser-laptop>
	<4AFAC90D.2020902@windriver.com>
Message-ID: <4AFAD08D.6070707@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



Tom wrote:
> Peter Tyser wrote:
>> <snip>
>>
>>>>>>> --- a/Makefile
>>>>>>> +++ b/Makefile
>>>>>>> @@ -3168,6 +3168,9 @@ omap3_zoom1_config :    unconfig
>>>>>>>  omap3_zoom2_config : unconfig
>>>>>>>       @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd
>>>>>>> omap3
>>>>>>>
>>>>>>> +omap3_cm-t35_config :        unconfig
>>>>>>> +     @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 cm-t35 NULL omap3
>>>>>>> +
>>>> I'd title your _config rule the same as your board name, ie drop the
>>>> omap3_ prefix above.  And the above list should be alphabetically
>>>> sorted.
>>> I'd prefer to keep the 'omap3_' prefix to stay inline with other
>>> omap3 boards.
>>
>> Just because the other omap3_ board are wrong doesn't mean your board
>> should be too:)  This same question was discussed for the devkit8000:
>> http://www.mail-archive.com/u-boot at lists.denx.de/msg21317.html
>>
> 
> Please drop the omap3_ prefix.
> New boards are following the standard convention.

Ok

> Tom
> 
> 

-- 
Sincerely yours,
Mike.