From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Wed, 11 Nov 2009 14:45:10 -0800 Subject: [U-Boot] [PATCH 2/5] smc911x: use dev->name in printfs In-Reply-To: <200911111736.25290.vapier@gentoo.org> References: <200911111711.04276.vapier@gentoo.org> <200911111736.25290.vapier@gentoo.org> Message-ID: <4AFB3E76.9090906@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mike, Mike Frysinger wrote: > On Wednesday 11 November 2009 17:24:27 Mike Rapoport wrote: > >> On Thu, Nov 12, 2009 at 12:11 AM, Mike Frysinger wrote: >> >>> On Wednesday 11 November 2009 16:56:57 Mike Rapoport wrote: >>> >>>> It seems that eeprom code is broken since commit >>>> 736fead8fdbf8a8407048bebc373cd551d01ec98: "Convert SMC911X Ethernet >>>> driver to CONFIG_NET_MULTI API". >>>> >>> broken how ? i recall it working ... >>> >> It gives pretty long list of compile errors. The smc911x.h header has >> now 'struct eth_device *dev' parameter in all the functions. >> > > yeah, i see that now. it wasnt noticed earlier as the config name changed but > the eeprom code wasnt updated. i can take a look if you like since i wrote > this sucker in the first place. > -mike > > You fixed the SMC91111 eeprom code by defining a 'struct eth_dev', but I guess not the SMC9111x. I'm responsible for making this mess, so if you don't have time I can take care of it (without being able to test, of course :) We can probably still fit such a bug fix in this release if we act quickly. regards, Ben