From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 12 Nov 2009 09:14:21 +0100 Subject: [U-Boot] redundant code in common/cmd_i2c. In-Reply-To: <880fa7950911110714w54afa0a4h896dcb64dc82e4c0@mail.gmail.com> References: <880fa7950911110714w54afa0a4h896dcb64dc82e4c0@mail.gmail.com> Message-ID: <4AFBC3DD.5080800@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello PratapChandu, PratapChandu wrote: > The following code fragment in the file common/cmd_i2c.c seems to be redundant. > Is not good to delete ? > > Line 330 - 336 is like below > > #if 0 > for (timeout = 0; timeout < 10; timeout++) { > udelay(2000); > if (i2c_probe(chip) == 0) > break; > } > #endif Yes, this seems to be dead code. Please provide a patch for removing it. Thanks. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany