From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Rapoport <mike@compulab.co.il>
Date: Thu, 12 Nov 2009 15:35:08 +0200
Subject: [U-Boot] [PATCH] smc911x: make smc911x_initialize return correct
 value (Was: Re: [PATCH 1/5] smc911x: return -1 when initialization fails)
In-Reply-To: <200911111016.49241.vapier@gentoo.org>
References: <cover.1257861401.git.mike@compulab.co.il>	<0a5257332d4a928fa67e2ee9108839126bf88b0a.1257861401.git.mike@compulab.co.il>
	<200911111016.49241.vapier@gentoo.org>
Message-ID: <4AFC0F0C.1030709@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Mike Frysinger wrote:
> On Wednesday 11 November 2009 03:03:00 Mike Rapoport wrote:
>> --- a/drivers/net/smc911x.c
>> +++ b/drivers/net/smc911x.c
>> @@ -243,7 +243,7 @@
>>  	dev = malloc(sizeof(*dev));
>>  	if (!dev) {
>>  		free(dev);
>> -		return 0;
>> +		return -1;
>>  	}
> 
> this is correct as this is an error
> 
>> @@ -252,7 +252,7 @@
>>  	/* Try to detect chip. Will fail if not present. */
>>  	if (smc911x_detect_chip(dev)) {
>>  		free(dev);
>> -		return 0;
>> +		return -1;
>>  	}
> 
> this is not -- we want it to return 0 if no parts are found.  see recent net 
> doc updates and discussions.
> -mike

Hope this one is better: