From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] OMAP3: pandora: fix booting without serial attached
Date: Thu, 12 Nov 2009 07:39:24 -0600 [thread overview]
Message-ID: <4AFC100C.1040001@windriver.com> (raw)
In-Reply-To: <1258019167-5379-1-git-send-email-notasas@gmail.com>
Grazvydas Ignotas wrote:
> When the board is booted without serial cable attached (which
> is how most of them will be used) UART RX is left floating and
> sometimes picks noise, which interrupts countdown and enters
> U-Boot prompt instead of booting the kernel.
>
> Fix this by setting up internal pullup on UART RX pin. This
> does not prevent serial from working as the internal pullup
> is weak.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Ack.
Thanks.
> ---
> It would be nice for this to go in as a fix for 2009.11,
> else users without serial cable won't be able to boot it.
>
Wolfgang,
Can this fix be included in 2009.11 ?
Tom
> board/pandora/pandora.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/board/pandora/pandora.h b/board/pandora/pandora.h
> index 5bfa0f9..f0ad16b 100644
> --- a/board/pandora/pandora.h
> +++ b/board/pandora/pandora.h
> @@ -219,7 +219,8 @@ const omap3_sysinfo sysinfo = {
> MUX_VAL(CP(UART2_RX), (IEN | PTD | EN | M4)) /*GPIO_147,*/\
> /*UART2_RX*/\
> /*Serial Interface (Peripheral boot, Linux console, on AV connector)*/\
> - MUX_VAL(CP(UART3_RX_IRRX), (IEN | PTD | DIS | M0)) /*UART3_RX*/\
> + /*RX pulled up to avoid noise when nothing is connected to serial port*/\
> + MUX_VAL(CP(UART3_RX_IRRX), (IEN | PTU | EN | M0)) /*UART3_RX*/\
> MUX_VAL(CP(UART3_TX_IRTX), (IDIS | PTD | DIS | M0)) /*UART3_TX*/\
> /*LEDs (Controlled by OMAP)*/\
> MUX_VAL(CP(MMC1_DAT6), (IDIS | PTD | DIS | M4)) /*GPIO_128*/\
next prev parent reply other threads:[~2009-11-12 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 9:46 [U-Boot] [PATCH v2] OMAP3: pandora: fix booting without serial attached Grazvydas Ignotas
2009-11-12 13:39 ` Tom [this message]
2009-11-17 23:16 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFC100C.1040001@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox