public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: kevin.morfitt at fearnside-systems.co.uk <kevin.morfitt@fearnside-systems.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH ARM] Add a unified s3c24x0 header file
Date: Fri, 13 Nov 2009 09:36:15 +0000	[thread overview]
Message-ID: <4AFD288F.7050201@fearnside-systems.co.uk> (raw)
In-Reply-To: <1f3430fb0911130126y7d0077b4v4c070bcadc653557@mail.gmail.com>



Minkyu Kang wrote:
> Dear Kevin Morifitt,
> 
> 2009/11/13 kevin.morfitt at fearnside-systems.co.uk
> <kevin.morfitt@fearnside-systems.co.uk>:
>> Hi Minky
>>
>>
>> Minkyu Kang wrote:
>>> Dear Kevin Morfitt
>>>
>>> 2009/11/10 kevin.morfitt at fearnside-systems.co.uk
>>> <kevin.morfitt@fearnside-systems.co.uk>:
>>>> This patch adds a unified s3c24x0 cpu header file that selects the header
>>>> file for the specific s3c24x0 cpu from the SOC and CPU configs defined in
>>>> board config file. This removes the current chain of s3c24-type #ifdef's
>>>> from the s3c24x0 code.
>>>>
>>>> Signed-off-by: Kevin Morfitt <kevin.morfitt@fearnside-systems.co.uk>
>>>>
<snip>
>>>>
>>>>  #include <nand.h>
>>>>  #include <linux/mtd/nand_ecc.h>
>>>> -#include <asm/arch/s3c2410.h>
>>>> +#include <asm/arch/s3c24x0_cpu.h>
>>>>  #include <asm/io.h>
>>> patch failed at s3c2410_nand.c
>>>
>>> patching file drivers/mtd/nand/s3c2410_nand.c
>>> Hunk #1 FAILED at 26.
>>> 1 out of 1 hunk FAILED -- saving rejects to file
>>> drivers/mtd/nand/s3c2410_nand.c.rej
>>>
>>> please check it
>> This patch assumes that my previous patch,
>> [U-Boot] [PATCH ARM] Update the s3c2410 nand driver from linux-2.6.31.5 had
>> already been applied.
>>
>> Would you like me to re-base this one to the current u-boot-samsung, or wait
>> until you've looked at [U-Boot] [PATCH ARM] Update the s3c2410 nand driver
>> from linux-2.6.31.5?
> 
> applied where?
> I couldn't find :(

It's not been accepted yet, I submitted it on 5th November, see 
http://lists.denx.de/pipermail/u-boot/2009-November/063866.html.

> 
>> Kevin
>>
>>>>  #if defined(CONFIG_S3C2410_NAND_HWECC) && defined(CONFIG_SYS_NAND_LARGEPAGE)
>>>> diff --git a/drivers/rtc/s3c24x0_rtc.c b/drivers/rtc/s3c24x0_rtc.c
>>>> index 2d78f93..04de5ca 100644
>>>> --- a/drivers/rtc/s3c24x0_rtc.c
>>>> +++ b/drivers/rtc/s3c24x0_rtc.c
>>>> @@ -30,11 +30,7 @@
<snip>
> 
> 
> 

  reply	other threads:[~2009-11-13  9:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04  8:49 [U-Boot] [PATCH ARM v2] Clean-up of s3c24x0 header files kevin.morfitt at fearnside-systems.co.uk
2009-11-10  2:15 ` Minkyu Kang
2009-11-10 13:06 ` [U-Boot] [PATCH ARM] Add a unified s3c24x0 header file kevin.morfitt at fearnside-systems.co.uk
2009-11-13  7:20   ` Minkyu Kang
2009-11-13  8:54     ` kevin.morfitt at fearnside-systems.co.uk
2009-11-13  9:26       ` Minkyu Kang
2009-11-13  9:36         ` kevin.morfitt at fearnside-systems.co.uk [this message]
2009-11-16  7:40           ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFD288F.7050201@fearnside-systems.co.uk \
    --to=kevin.morfitt@fearnside-systems.co.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox