public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Help command broken on AT91SAM9G10-EK
Date: Fri, 13 Nov 2009 10:49:33 -0600	[thread overview]
Message-ID: <4AFD8E1D.30803@windriver.com> (raw)
In-Reply-To: <1258128627.30127.18.camel@jjw-linux>

Justin Waters wrote:
> It looks like the "help" command is broken on the AT91SAM9G10-EK on
> 2009.11-rc1.  I get the following message any time I try to run it:
> 
> Unknown command 'help' - try 'help'
> 
> I've bisected the issue, and it looks like it started with the addition
> of the "editenv" command (commit
> 246c69225c7b962d5c93e92282b78ca9fc5fefee).  
> 
> After some further digging, I found some weirdness with the help command
> beginning with the lead-up work to the editenv commit. Strange
> characters where being printed to the console whenever the help command
> was run.  This issue started with commit
> ecc5500ee487170d8af6ff893fd1e0082380a01a, readline(): Add ability to
> modify a string buffer.
> 
> I've also tested the AT91SAM9263-EK, and everything looks great.  I
> believe the difference is related to the fact that the 9G10 does not use
> hush, while the 9263 does. Indeed, if you look at the main loop,
> non-hush systems use "readline" (which is indirectly modified by the
> aforementioned commits), while hush systems do not.
> 
> I'm not really sure what would be the best way to fix this.  Any ideas?
> 

What is the impact of just reverting the commits ?
Tom

> -Justin Waters
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2009-11-13 16:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 16:10 [U-Boot] Help command broken on AT91SAM9G10-EK Justin Waters
2009-11-13 16:49 ` Tom [this message]
2009-11-13 16:50 ` Peter Tyser
2009-11-13 17:01   ` Justin Waters
2009-11-13 17:50     ` Peter Tyser
2009-11-13 21:24       ` Justin Waters
2009-11-13 21:39         ` Peter Tyser
2009-11-13 22:10           ` Justin Waters
2009-11-13 22:37             ` Justin Waters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFD8E1D.30803@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox