From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Date: Fri, 13 Nov 2009 11:28:37 -0600 Subject: [U-Boot] [PATCH v3] DA8xx: Add MUSB host support In-Reply-To: <19F8576C6E063C45BE387C64729E73940436981184@dbde02.ent.ti.com> References: <1258117521-31667-1-git-send-email-ajay.gupta@ti.com>, <4AFD6B9C.2090704@gefanuc.com> <19F8576C6E063C45BE387C64729E73940436981181@dbde02.ent.ti.com>, <4AFD91ED.5010909@windriver.com> <19F8576C6E063C45BE387C64729E73940436981184@dbde02.ent.ti.com> Message-ID: <4AFD9745.3090402@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Gupta, Ajay Kumar wrote: > Hi, >> Hi, >>> Tested USB host functionality on DA830 EVM. >>> >>> Signed-off-by: Ajay Kumar Gupta >>> Signed-off-by: Swaminathan S >>> --- >> >> >>> --- a/include/usb.h >>> +++ b/include/usb.h >>> @@ -183,7 +183,8 @@ struct usb_device { >>> #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ >>> defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ >>> defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ >>> - defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) >>> + defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \ >>> + defined(CONFIG_USB_DA8XX) >>> These are aligned incorrectly (should be 4 spaces rather than a tab) >> It was originally with tabs only. Are you suggesting to change all 5 lines to match the alignment ? >> >> Tom, >> What do you think on this one? > >> In general tabs are preferred but I would like to review the entire patchset. >> When you make changes to a subset of the patches, you must repost the entire >> patchset. > >> Please repost the entire patchset. > > Ok sure. Shall I post this patch with tabs or with 4-spaces as Nick suggested ? > Just repost it as-is. Please be aware that this is a USB change. And though I can provide some input the ack/nak decision is Remy's. Tom > Regards, > Ajay > >> Tom > > >> -Ajay > >