From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] makefiles: fixes for building build tools
Date: Fri, 13 Nov 2009 12:53:45 -0600 [thread overview]
Message-ID: <4AFDAB39.1080202@freescale.com> (raw)
In-Reply-To: <200911131351.12907.vapier@gentoo.org>
Mike Frysinger wrote:
> On Wednesday 04 November 2009 19:41:41 Scott Wood wrote:
>> --- a/rules.mk
>> +++ b/rules.mk
>>
>> +$(HOSTOBJS): $(obj)%.o: %.c
>> + $(HOSTCC) $(HOSTCFLAGS) $(HOSTCFLAGS_$(@F)) $(HOSTCFLAGS_$(BCURDIR)) -o
>> $@ $< -c
>> +$(NOPEDOBJS): $(obj)%.o: %.c
>> + $(HOSTCC) $(HOSTCFLAGS_NOPED) $(HOSTCFLAGS_$(@F))
>> $(HOSTCFLAGS_$(BCURDIR)) -o $@ $< -c
>
> wouldnt these make more sense in config.mk with all the other patterns.
The static pattern rules won't work unless $(HOSTOBJS)/$(NOPEDOBJS) has
been filled in by the makefile. config.mk is included too early for that.
A non-static pattern won't work unless we can distinguish between
target, host-pedantic, and host-no-pedantic from the filename or path alone.
Plus, the name of the file is *rules*.mk. :-)
> and create a pattern target for creating host executables.
That would be nice to have, but is orthogonal to what this patch does.
One thing at a time.
-Scott
next prev parent reply other threads:[~2009-11-13 18:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 0:41 [U-Boot] [PATCH v2] makefiles: fixes for building build tools Scott Wood
2009-11-13 18:51 ` Mike Frysinger
2009-11-13 18:53 ` Scott Wood [this message]
2009-11-13 23:07 ` Mike Frysinger
2009-12-02 21:59 ` Wolfgang Denk
2009-12-03 7:26 ` Stefan Roese
2009-12-03 17:49 ` Scott Wood
2009-12-03 18:17 ` Stefan Roese
2009-12-03 19:09 ` Scott Wood
2009-12-04 3:45 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFDAB39.1080202@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox