public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Rapoport <mike@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config
Date: Sun, 15 Nov 2009 11:22:21 +0200	[thread overview]
Message-ID: <4AFFC84D.9050903@compulab.co.il> (raw)
In-Reply-To: <1257926592-14782-3-git-send-email-mike@compulab.co.il>

Any comments on this?

Mike Rapoport wrote:
> There are several presets for GPMC registers defined in
> include/asm-arm/arch-omap3/mem.h. Allow selection between SMNAND and
> M_NAND presets based on OMAP34XX_GPMC_NAND_<PART> defines
> 
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
> ---
>  cpu/arm_cortexa8/omap3/mem.c |   25 ++++++++++++++++---------
>  1 files changed, 16 insertions(+), 9 deletions(-)
> 
> diff --git a/cpu/arm_cortexa8/omap3/mem.c b/cpu/arm_cortexa8/omap3/mem.c
> index 8b8cd6d..2bd7e1c 100644
> --- a/cpu/arm_cortexa8/omap3/mem.c
> +++ b/cpu/arm_cortexa8/omap3/mem.c
> @@ -44,14 +44,21 @@ volatile unsigned int boot_flash_env_addr;
>  struct gpmc *gpmc_cfg;
>  
>  #if defined(CONFIG_CMD_NAND)
> -static const u32 gpmc_m_nand[GPMC_MAX_REG] = {
> -	M_NAND_GPMC_CONFIG1,
> -	M_NAND_GPMC_CONFIG2,
> -	M_NAND_GPMC_CONFIG3,
> -	M_NAND_GPMC_CONFIG4,
> -	M_NAND_GPMC_CONFIG5,
> -	M_NAND_GPMC_CONFIG6, 0
> -};
> +#define GPMC_NAND(PART)					\
> +	static const u32 gpmc_nand[GPMC_MAX_REG] = {	\
> +		PART##_GPMC_CONFIG1,			\
> +		PART##_GPMC_CONFIG2,			\
> +		PART##_GPMC_CONFIG3,			\
> +		PART##_GPMC_CONFIG4,			\
> +		PART##_GPMC_CONFIG5,			\
> +		PART##_GPMC_CONFIG6, 0			\
> +	};
> +
> +#ifdef OMAP34XX_GPMC_NAND_SMNAND
> +GPMC_NAND(SMNAND)
> +#else
> +GPMC_NAND(M_NAND)
> +#endif
>  
>  #if defined(CONFIG_ENV_IS_IN_NAND)
>  #define GPMC_CS 0
> @@ -246,7 +253,7 @@ void gpmc_init(void)
>  	sdelay(1000);
>  
>  #if defined(CONFIG_CMD_NAND)	/* CS 0 */
> -	gpmc_config = gpmc_m_nand;
> +	gpmc_config = gpmc_nand;
>  
>  	base = PISMO1_NAND_BASE;
>  	size = PISMO1_NAND_SIZE;

-- 
Sincerely yours,
Mike.

  reply	other threads:[~2009-11-15  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11  8:03 [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config Mike Rapoport
2009-11-15  9:22 ` Mike Rapoport [this message]
2009-11-15 16:36   ` Tom
2009-11-15 19:25     ` Mike Rapoport
2009-11-15 19:41     ` Nishanth Menon
2009-11-15 20:08       ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFFC84D.9050903@compulab.co.il \
    --to=mike@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox