public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board
Date: Sun, 15 Nov 2009 14:34:14 -0600	[thread overview]
Message-ID: <4B0065C6.1080000@windriver.com> (raw)
In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D9402513C@dlee01.ent.ti.com>

Paulraj, Sandeep wrote:
>> Add CM-T35 board support
>>

Please add more description of the board.

>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>>
>> --
>> v2 changes:
>> - rename board config file from omap3_cm-t35.h to cm-t35.h
>> - remove SZ_xx references
>> - add MAKEALL/MAINTEINERS entries


Wolfgang had made this comment on V2 that has not been addressed.

>  > diff --git a/include/configs/cm-t35.h b/include/configs/cm-t35.h
> > new file mode 100755
> > > index 0000000..b881112
> > > --- /dev/null
> > > +++ b/include/configs/cm-t35.h
> ...
> > > +#ifndef __ASSEMBLY__
> > > +extern struct gpmc *gpmc_cfg;
> > > +extern unsigned int boot_flash_base;
> > > +extern volatile unsigned int boot_flash_env_addr;
> > > +extern unsigned int boot_flash_off;
> > > +extern unsigned int boot_flash_sec;
> > > +extern unsigned int boot_flash_type;
> > > +#endif
> 
> These should not be needed in your board config file. Please move to a
> more appropriate header.
> 
> Best regards,
> 
> Wolfgang Denk

Please do not push this change.

Tom

  reply	other threads:[~2009-11-15 20:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-15 14:47 [U-Boot] [PATCH v4] OMAP3: add CM-T35 board Mike Rapoport
2009-11-15 18:58 ` Paulraj, Sandeep
2009-11-15 20:34   ` Tom [this message]
2009-11-16  9:14     ` Mike Rapoport
2009-11-16 13:14       ` Tom
2009-11-16 14:03         ` Mike Rapoport
2009-11-16 21:16           ` Tom
2009-11-17 20:18       ` Wolfgang Denk
2009-11-15 21:20 ` Wolfgang Denk
2009-11-16  6:42   ` Mike Rapoport
2009-11-15 21:47 ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0065C6.1080000@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox