From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Date: Sun, 15 Nov 2009 14:34:14 -0600 Subject: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D9402513C@dlee01.ent.ti.com> References: <1258296430-19678-1-git-send-email-mike@compulab.co.il> <0554BEF07D437848AF01B9C9B5F0BC5D9402513C@dlee01.ent.ti.com> Message-ID: <4B0065C6.1080000@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Paulraj, Sandeep wrote: >> Add CM-T35 board support >> Please add more description of the board. >> Signed-off-by: Mike Rapoport >> >> -- >> v2 changes: >> - rename board config file from omap3_cm-t35.h to cm-t35.h >> - remove SZ_xx references >> - add MAKEALL/MAINTEINERS entries Wolfgang had made this comment on V2 that has not been addressed. > > diff --git a/include/configs/cm-t35.h b/include/configs/cm-t35.h > > new file mode 100755 > > > index 0000000..b881112 > > > --- /dev/null > > > +++ b/include/configs/cm-t35.h > ... > > > +#ifndef __ASSEMBLY__ > > > +extern struct gpmc *gpmc_cfg; > > > +extern unsigned int boot_flash_base; > > > +extern volatile unsigned int boot_flash_env_addr; > > > +extern unsigned int boot_flash_off; > > > +extern unsigned int boot_flash_sec; > > > +extern unsigned int boot_flash_type; > > > +#endif > > These should not be needed in your board config file. Please move to a > more appropriate header. > > Best regards, > > Wolfgang Denk Please do not push this change. Tom