From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Rapoport <mike@compulab.co.il>
Date: Mon, 16 Nov 2009 11:14:02 +0200
Subject: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board
In-Reply-To: <4B0065C6.1080000@windriver.com>
References: <1258296430-19678-1-git-send-email-mike@compulab.co.il>
	<0554BEF07D437848AF01B9C9B5F0BC5D9402513C@dlee01.ent.ti.com>
	<4B0065C6.1080000@windriver.com>
Message-ID: <4B0117DA.2020509@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Tom,

Tom wrote:
> Paulraj, Sandeep wrote:
>>> Add CM-T35 board support
>>>
> 
> Please add more description of the board.
> 
>>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>>>
>>> -- 
>>> v2 changes:
>>> - rename board config file from omap3_cm-t35.h to cm-t35.h
>>> - remove SZ_xx references
>>> - add MAKEALL/MAINTEINERS entries
> 
> 
> Wolfgang had made this comment on V2 that has not been addressed.
>
>>  > diff --git a/include/configs/cm-t35.h b/include/configs/cm-t35.h
>> > new file mode 100755
>> > > index 0000000..b881112
>> > > --- /dev/null
>> > > +++ b/include/configs/cm-t35.h
>> ...
>> > > +#ifndef __ASSEMBLY__
>> > > +extern struct gpmc *gpmc_cfg;
>> > > +extern unsigned int boot_flash_base;
>> > > +extern volatile unsigned int boot_flash_env_addr;
>> > > +extern unsigned int boot_flash_off;
>> > > +extern unsigned int boot_flash_sec;
>> > > +extern unsigned int boot_flash_type;
>> > > +#endif
>>
>> These should not be needed in your board config file. Please move to a
>> more appropriate header.

As I've already answered Wolfgang ([1]), this is what _all_ other omap3 board
do... Moving these requires rework of common omap3 code and updates to all omap3
boards.


[1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/71466

>> Best regards,
>>
>> Wolfgang Denk
> 
> Please do not push this change.
> 
> Tom
> 
> 

-- 
Sincerely yours,
Mike.