From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board
Date: Mon, 16 Nov 2009 15:16:30 -0600 [thread overview]
Message-ID: <4B01C12E.6010401@windriver.com> (raw)
In-Reply-To: <4B015BAF.7010509@compulab.co.il>
Mike Rapoport wrote:
>
<snip>
>>>
>>>
>> Yes this change would apply to all the omap3 boards.
>> But it looks like they are are all the same change.
>>
>> The change per board, would be to delete these externs once the
>> first code change is made.
>>
>> Since this is a code movement change, it can be verified by running
>> MAKEALL arm before and after the change.
>
> The problem here, that just moving these externs to e.g.
> include/arm-arm/arch-omap3/mem.h is not enough. All omap3 boards set environment
> related defines to these externs, and therefore without them common/env_nand
> does not build. It seems that all the board_flash_* variables can be completely
> removed completely, but I really don't know what was the original author
> intention about those variables.
>
I have posted a patch for the first part of this problem with gpmc.
I am testing a change now to remove the board_flash_* variables.
After that I think we will be ok.
Tom
next prev parent reply other threads:[~2009-11-16 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 14:47 [U-Boot] [PATCH v4] OMAP3: add CM-T35 board Mike Rapoport
2009-11-15 18:58 ` Paulraj, Sandeep
2009-11-15 20:34 ` Tom
2009-11-16 9:14 ` Mike Rapoport
2009-11-16 13:14 ` Tom
2009-11-16 14:03 ` Mike Rapoport
2009-11-16 21:16 ` Tom [this message]
2009-11-17 20:18 ` Wolfgang Denk
2009-11-15 21:20 ` Wolfgang Denk
2009-11-16 6:42 ` Mike Rapoport
2009-11-15 21:47 ` Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B01C12E.6010401@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox