From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Date: Mon, 16 Nov 2009 15:16:30 -0600 Subject: [U-Boot] [PATCH v4] OMAP3: add CM-T35 board In-Reply-To: <4B015BAF.7010509@compulab.co.il> References: <1258296430-19678-1-git-send-email-mike@compulab.co.il> <0554BEF07D437848AF01B9C9B5F0BC5D9402513C@dlee01.ent.ti.com> <4B0065C6.1080000@windriver.com> <4B0117DA.2020509@compulab.co.il> <4B01502C.8040303@windriver.com> <4B015BAF.7010509@compulab.co.il> Message-ID: <4B01C12E.6010401@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike Rapoport wrote: > >>> >>> >> Yes this change would apply to all the omap3 boards. >> But it looks like they are are all the same change. >> >> The change per board, would be to delete these externs once the >> first code change is made. >> >> Since this is a code movement change, it can be verified by running >> MAKEALL arm before and after the change. > > The problem here, that just moving these externs to e.g. > include/arm-arm/arch-omap3/mem.h is not enough. All omap3 boards set environment > related defines to these externs, and therefore without them common/env_nand > does not build. It seems that all the board_flash_* variables can be completely > removed completely, but I really don't know what was the original author > intention about those variables. > I have posted a patch for the first part of this problem with gpmc. I am testing a change now to remove the board_flash_* variables. After that I think we will be ok. Tom