[U-Boot] [PATCH] flash.h: pull in common.h for types

Wolfgang Denk
2009-11-17T21:00:15Z

Dear Mike Frysinger,

In message <200911161703.46965.vapier@gentoo.org> you wrote:
>
> > Why would that be needed? Which problem are you trying to solve?
>
> like the subject very briefly says, 'for types'. if your source code includes
> flash.h before anything else, it'll fail to compile as flash.h uses types not
> declared implicitly by the compiler.

I'm not sure if this is needed or even wanted.

We don't attempt to make all header files self-sufficient, or do we?
Does Linux do this?

When looking at man pages for system calls and library funtions it
seems this is not the case; also, I can find wise people argumenting
against self-sufficient headers (and others argumenting in their
favour).

My question: is there a definitive position somewhere (for example
for the Linux kernel; I'm sure we don't have one for U-Boot [yet]),
whether system headers should be self-sufficient?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One does not thank logic.
-- Sarek, "Journey to Babel", stardate 3842.4