[U-Boot] [PATCH] flash.h: pull in common.h for types

Mike Frysinger
2009-11-16T22:03:32Z

On Monday 16 November 2009 16:31:27 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> > include/flash.h | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/flash.h b/include/flash.h
> > index c5e7bf4..886d8ef 100644
> > --- a/include/flash.h
> > +++ b/include/flash.h
> > @@ -25,6 +25,9 @@
> > #define _FLASH_H_
> >
> > #ifndef CONFIG_SYS_NO_FLASH
> > +
> > +#include <common.h>
> > +
>
> Why would that be needed? Which problem are you trying to solve?

like the subject very briefly says, 'for types'. if your source code includes
flash.h before anything else, it'll fail to compile as flash.h uses types not
declared implicitly by the compiler.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091116/d6081938/attachment.pgp