From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] why is the compilation of cmd_pcmcia.c hardcoded?
Date: Wed, 18 Nov 2009 09:37:18 -0800 [thread overview]
Message-ID: <4B0430CE.6020802@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0911180307560.31136@localhost>
Robert,
Robert P. J. Day wrote:
> i'm curious as to why common/Makefile hardcodes the compilation of
> cmd_pcmcia.c thusly:
>
> COBJS-y += cmd_pcmcia.o
>
> since i'm interested in building for a beagleboard, i have no interest
> in PCMCIA support, yet that source file will be compiled for me, even
> though the selection macro CONFIG_CMD_PCMCIA does exist and is defined
> by a number of other board configurations.
>
> what seems stranger is that, even though that config macro exists,
> it isn't used in the Makefile but *is* tested in the source file
> itself to determine whether the "pinit" command will be compiled:
>
> =====
> #if defined(CONFIG_CMD_PCMCIA)
>
If you look at the source code tree from a couple of years ago you'll
see that the pattern you've discovered used to be the norm. Over time,
people have been removing the source file wrappers and moving
conditionality to the Makefiles. It's a work in progress, and help
fixing things up is always appreciated.
regards,
Ben
next prev parent reply other threads:[~2009-11-18 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 8:17 [U-Boot] why is the compilation of cmd_pcmcia.c hardcoded? Robert P. J. Day
2009-11-18 17:37 ` Ben Warren [this message]
2009-11-19 0:15 ` Mike Frysinger
2009-12-07 20:16 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0430CE.6020802@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox