From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Thu, 26 Nov 2009 08:14:39 -0600
Subject: [U-Boot] [PATCH] AT91: revise serial lines pullup configuration,
In-Reply-To: <20091122210232.F04D8E34A27@gemini.denx.de>
References: <4A60EB7C.4010108@poczta.fm>
	<20091122210232.F04D8E34A27@gemini.denx.de>
Message-ID: <4B0E8D4F.9060404@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear Tom,
> 
> In message <4A60EB7C.4010108@poczta.fm> Andrzej Wolski wrote:
>> Currently pullups are incorrectly set for all AT91 SoCs:
>> pullup for TXD line is enabled, what is not necessary, but
>> pullup for RXD line, what may be necessary for some boards,
>> is disabled. This patch fixes it: it enables pullup only
>> for RXD line.
>>
>> Signed-off-by: Andrzej Wolski <awolski@poczta.fm>
> 
> Could you please check the status of this patch:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/64068
> 
> Best regards,
> 
> Wolfgang Denk
> 

Andrzej,
This patch looks similar to what was done recently for overo.
Please add a comment in the code to the setting of the pullup.
Please also add a comment to commit log explaining why this
needs to change, just saying it is wrong is not enough of
an explanation.  In the case of overo, the problem that was
fixed was random hangs when the serial wasn't connected.

Please also check is any new at91 boards were added since
you first submitted this patch.

Tom