From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Thu, 26 Nov 2009 10:04:24 -0600
Subject: [U-Boot] [PATCH 3/5] Added configuration file for AM3517EVM
In-Reply-To: <19F8576C6E063C45BE387C64729E739404370D7ACC@dbde02.ent.ti.com>
References: <hvaibhav@ti.com>	<1258974524-28097-1-git-send-email-hvaibhav@ti.com>	<20091123194619.8225C3F6D6@gemini.denx.de>
	<19F8576C6E063C45BE387C64729E739404370D7ACC@dbde02.ent.ti.com>
Message-ID: <4B0EA708.6060005@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hiremath, Vaibhav wrote:
>> -----Original Message-----
>> From: Wolfgang Denk [mailto:wd at denx.de]
>> Sent: Tuesday, November 24, 2009 1:16 AM
>> To: Hiremath, Vaibhav
>> Cc: u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [PATCH 3/5] Added configuration file for
>> AM3517EVM
>>
>> Dear hvaibhav at ti.com,
>>
>> In message <1258974524-28097-1-git-send-email-hvaibhav@ti.com> you
>> wrote:
>>> From: Vaibhav Hiremath <hvaibhav@ti.com>
>>>
>>>
>>> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
>>> ---
>>>  include/configs/am3517_evm.h |  293
>> ++++++++++++++++++++++++++++++++++++++++++
>>>  1 files changed, 293 insertions(+), 0 deletions(-)
>>>  create mode 100644 include/configs/am3517_evm.h
>> See before: this patch must be part of the commit that adds the
>> board
>> code.
>>
>>
>>> +#ifndef __ASSEMBLY__
>>> +extern struct gpmc *gpmc_cfg;
>>> +extern unsigned int boot_flash_base;
>>> +extern volatile unsigned int boot_flash_env_addr;
>>> +extern unsigned int boot_flash_off;
>>> +extern unsigned int boot_flash_sec;
>>> +extern unsigned int boot_flash_type;
>>> +#endif
>> Please add prototype declarations to some appropriate header file
>> instead.
>>
> [Hiremath, Vaibhav] Actually this code is borrowed from OMAP3EVM file, and I think almost all devices handles this same way.
> 
> It is bit difficult to handle this, since we are supporting multiple flash devices and these variables are initialized run-time and so the macros below,
> 
> CONFIG_SYS_FLASH_BASE,
> CONFIG_ENV_OFFSET,
> CONFIG_SYS_ENV_SECT_SIZE
> 
> I will try to dig bit more on this, but I think as of now we can go with this.

This code is changing so you may want to wait on investing a lot of
effort into it.  Please see the CM-T35 board submission.
Please review what is already been proposed to fix this for all the omap3's and
comment.

Tom

> 
> Thanks,
> Vaibhav
> 
>> Best regards,
>>
>> Wolfgang Denk