[U-Boot] [PATCH 4/5] AM3517EVM: Add mux configuration

Tom
2009-11-26T16:07:32Z

Hiremath, Vaibhav wrote:
>> -----Original Message-----
>> From: Wolfgang Denk [mailto:wd at denx.de]
>> Sent: Tuesday, November 24, 2009 1:19 AM
>> To: Hiremath, Vaibhav
>> Cc: u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [PATCH 4/5] AM3517EVM: Add mux configuration
>>
>> Dear hvaibhav at ti.com,
>>
>> In message <1258974539-28130-1-git-send-email-hvaibhav@ti.com> you
>> wrote:
>>> From: Vaibhav Hiremath <hvaibhav@ti.com>
>>>
>>> Updated mux.h file for AM3517 specific mux configuration.
>>>
>>> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
>>> ---
>>> include/asm-arm/arch-omap3/mux.h | 35
>> +++++++++++++++++++++++++++++++++++
>>> 1 files changed, 35 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/include/asm-arm/arch-omap3/mux.h b/include/asm-
>> arm/arch-omap3/mux.h
>>> index 0c01c73..9f06fbb 100644
>>> --- a/include/asm-arm/arch-omap3/mux.h
>>> +++ b/include/asm-arm/arch-omap3/mux.h
>>> @@ -403,6 +403,41 @@
>>> #define CONTROL_PADCONF_D2D_SBUSFLAG 0x0260
>>> #define CONTROL_PADCONF_SDRC_CKE0 0x0262
>>> #define CONTROL_PADCONF_SDRC_CKE1 0x0264
>>> +/* AM3517 specific */
>>> +#define CONTROL_PADCONF_CCDC_PCLK 0x01E4
>>> +#define CONTROL_PADCONF_CCDC_FIELD 0x01E6
>>> +#define CONTROL_PADCONF_CCDC_HD 0x01E8
>>> +#define CONTROL_PADCONF_CCDC_VD 0x01EA
>>> +#define CONTROL_PADCONF_CCDC_WEN 0x01EC
>> ...
>>
>> Where are these defines used? I think I don't see them in any of the
>> patches of this patch series?
>>
> [Hiremath, Vaibhav] These are being used in board/ty/am3517/am3517evm.c file under the function set_muxconf_regs().
>

It seems like these defines are only going to be used by the am3517.
If this is so, please move them to a board specific file.

Tom

> Thanks,
> Vaibhav
>
>> Best regards,
>>
>> Wolfgang Denk