[U-Boot] [PATCH 4/5] AM3517EVM: Add mux configuration

Wolfgang Denk
2009-12-05T00:23:08Z

Dear "Hiremath, Vaibhav",

In message <19F8576C6E063C45BE387C64729E739404370D7ACF@dbde02.ent.ti.com> you wrote:
>
> > > #define CONTROL_PADCONF_D2D_SBUSFLAG 0x0260
> > > #define CONTROL_PADCONF_SDRC_CKE0 0x0262
> > > #define CONTROL_PADCONF_SDRC_CKE1 0x0264
> > > +/* AM3517 specific */
> > > +#define CONTROL_PADCONF_CCDC_PCLK 0x01E4
> > > +#define CONTROL_PADCONF_CCDC_FIELD 0x01E6
> > > +#define CONTROL_PADCONF_CCDC_HD 0x01E8
> > > +#define CONTROL_PADCONF_CCDC_VD 0x01EA
> > > +#define CONTROL_PADCONF_CCDC_WEN 0x01EC
> > ...
> >
> > Where are these defines used? I think I don't see them in any of the
> > patches of this patch series?
> >
> [Hiremath, Vaibhav] These are being used in board/ty/am3517/am3517evm.c
> file under the function set_muxconf_regs().

As Tom noted it probably makes sense to move these to a board specific
file.

But then, this looks very much like register offsets for some device.
If this should be the case, plase make sure to convert this into a C
struct and use appropriate accesor macros.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The so-called "desktop metaphor" of today's workstations is instead
an "airplane-seat" metaphor. Anyone who has shuffled a lap full of
papers while seated between two portly passengers will recognize the
difference -- one can see only a very few things at once.
- Fred Brooks, Jr.