[U-Boot] [PATCH-V3 1/2] AM35x: Add support for AM3517EVM

Wolfgang Denk
2010-05-31T09:40:56Z

Dear hvaibhav at ti.com,

In message <1273166585-26101-1-git-send-email-hvaibhav@ti.com> you wrote:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
>
> This patch adds basic support for the AM3517EVM.
> It includes:
> - Board int file (.c and .h)
> - Default configuration file
> - Updates for Makefile
>
> Changes from V2:
> - Removed trailing spaces
> - Updated MAINTAINERS & MAKEALL for am3517_evm

Such comments do not belong into the commit message. Please place thes
ebelow the "---" line:

> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---

==> Comments should go here.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5cbc845..0bc65e1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -798,6 +798,10 @@ Alex Z
> lart SA1100
> dnp1110 SA1110
>
> +Vaibhav Hiremath <hvaibhav@ti.com>
> +
> + am3517_evm ARM CORTEX-A8 (AM35x SoC)
> +

Please keep list sorted.

...
> diff --git a/arch/arm/include/asm/arch-omap3/mux.h b/arch/arm/include/asm/arch-omap3/mux.h
> index 0c01c73..ffeb982 100644
> --- a/arch/arm/include/asm/arch-omap3/mux.h
> +++ b/arch/arm/include/asm/arch-omap3/mux.h
...
> +/* AM3517 specific */
> +#define CONTROL_PADCONF_CCDC_PCLK 0x01E4
> +#define CONTROL_PADCONF_CCDC_FIELD 0x01E6

Board specific defoinitions should not be added to global header
files. Please use a board specific header instead.

> --- /dev/null
> +++ b/board/logicpd/am3517evm/am3517evm.c
> @@ -0,0 +1,76 @@
...
> +int board_init(void)
> +{
> + DECLARE_GLOBAL_DATA_PTR;

This is bound to break. DECLARE_GLOBAL_DATA_PTR must always be used on
file scope only; never use this on function scope. Please check all
your code.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Genius doesn't work on an assembly line basis. You can't simply say,
"Today I will be brilliant."
-- Kirk, "The Ultimate Computer", stardate 4731.3