[U-Boot] [PATCH-V2 3/4] AM35x: Add support for AM3517EVM

Wolfgang Denk
2010-05-05T20:12:13Z

Dear hvaibhav at ti.com,

In message <1272034546-26041-5-git-send-email-hvaibhav@ti.com> you wrote:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
>
> This patch adds basic support for the AM3517EVM.
> It includes:
> - Board int file (.c and .h)
> - Default configuration file
> - Updates for Makefile
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
> Makefile | 3 +
> arch/arm/include/asm/arch-omap3/mux.h | 36 +++
> board/logicpd/am3517evm/Makefile | 47 ++++
> board/logicpd/am3517evm/am3517evm.c | 76 ++++++
> board/logicpd/am3517evm/am3517evm.h | 405 +++++++++++++++++++++++++++++++++
> board/logicpd/am3517evm/config.mk | 30 +++
> include/configs/am3517_evm.h | 297 ++++++++++++++++++++++++
> 7 files changed, 894 insertions(+), 0 deletions(-)
> create mode 100644 board/logicpd/am3517evm/Makefile
> create mode 100644 board/logicpd/am3517evm/am3517evm.c
> create mode 100644 board/logicpd/am3517evm/am3517evm.h
> create mode 100644 board/logicpd/am3517evm/config.mk
> create mode 100644 include/configs/am3517_evm.h

Entries to MAKEALL and MAINTAINERS missing.

> diff --git a/Makefile b/Makefile
> index 34f10ce..487ae73 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3169,6 +3169,9 @@ omap3_zoom1_config : unconfig
> omap3_zoom2_config : unconfig
> @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
>
> +am3517_evm_config : unconfig
> + @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 am3517evm logicpd omap3
> +
> smdkc100_config: unconfig
> @$(MKCONFIG) $(@:_config=) arm arm_cortexa8 smdkc100 samsung s5pc1xx

Please keep list sorted.

> diff --git a/arch/arm/include/asm/arch-omap3/mux.h b/arch/arm/include/asm/arch-omap3/mux.h
> index 0c01c73..8ea47b6 100644
> --- a/arch/arm/include/asm/arch-omap3/mux.h
> +++ b/arch/arm/include/asm/arch-omap3/mux.h
> @@ -283,6 +283,7 @@
> /*Control and debug */
> #define CONTROL_PADCONF_SYS_32K 0x0A04
> #define CONTROL_PADCONF_SYS_CLKREQ 0x0A06
> +#define CONTROL_PADCONF_SYS_NRESWARM 0x0A08
> #define CONTROL_PADCONF_SYS_NIRQ 0x01E0
> #define CONTROL_PADCONF_SYS_BOOT0 0x0A0A
> #define CONTROL_PADCONF_SYS_BOOT1 0x0A0C

CONTROL_PADCONF_SYS_NIRQ looks out of place here. And all this asks
to be converted into a proper C struct.

> diff --git a/board/logicpd/am3517evm/Makefile b/board/logicpd/am3517evm/Makefile
> new file mode 100644
> index 0000000..3c71fef
> --- /dev/null
> +++ b/board/logicpd/am3517evm/Makefile
...
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +

Don't add trailing empty lines. [Please check & fix globally.]

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Any sufficiently advanced technology is indistinguishable from magic.
Clarke's Third Law - _Profiles of the Future_ (1962; rev. 1973)
``Hazards of Prophecy: The Failure of Imagination''