From: "\"Seunghyeon Rhee (이승현)\"" <seunghyeon@lpmtec.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] samsung: fix DMC1_MEM_CFG for s3c64xx
Date: Sat, 28 Nov 2009 10:26:33 +0900 [thread overview]
Message-ID: <4B107C49.8050006@lpmtec.com> (raw)
The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control
for S3C6400. In the configuration of SMDK6400, however, two 16-bit
mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit
memory bus and there is no need to contorl CKE for each chip
separately. AFAIK, CKE1 is not at all connected. Only CKE0 is
used. Futhermore, it should be '0' always for S3C6410. When tested
with a board which has a S3C6410 and the same memory configuration,
a side effect is obsearved that u-boot command "reset" doesn't work
leading to system hang. Leaving the bit clear is safe in most cases.
Signed-off-by: Seunghyeon Rhee <seunghyeon@lpmtec.com>
---
include/s3c6400.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/s3c6400.h b/include/s3c6400.h
index e527c08..7229ea6 100644
--- a/include/s3c6400.h
+++ b/include/s3c6400.h
@@ -817,7 +817,7 @@
/*-----------------------------------------------------------------------
* Physical Memory Map
*/
-#define DMC1_MEM_CFG 0x80010012 /* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG 0x00010012 /* Chip1, Burst4, Row/Column bit */
#define DMC1_MEM_CFG2 0xB45
#define DMC1_CHIP0_CFG 0x150F8 /* 0x4000_0000 ~ 0x43ff_ffff (64MB) */
#define DMC_DDR_32_CFG 0x0 /* 32bit, DDR */
--
1.6.2.5
--
Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007 F +82-2-6442-6462
M +82-10-2790-0657
next reply other threads:[~2009-11-28 1:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 1:26 "Seunghyeon Rhee (이승현)" [this message]
2009-12-02 4:49 ` [U-Boot] [PATCH] samsung: fix DMC1_MEM_CFG for s3c64xx Minkyu Kang
2009-12-02 5:32 ` Seunghyeon Rhee
2009-12-03 0:41 ` [U-Boot] [PATCH (repost)] " Seunghyeon Rhee
2009-12-04 0:16 ` Minkyu Kang
2009-12-05 0:59 ` Wolfgang Denk
2009-12-05 2:52 ` Minkyu Kang
2009-12-05 0:56 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B107C49.8050006@lpmtec.com \
--to=seunghyeon@lpmtec.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox