From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sun, 29 Nov 2009 11:34:07 +0100 Subject: [U-Boot] [PATCH V2 1/3] Initial support for Marvell Orion5x SoC In-Reply-To: <20091118221716.80D933F6C2@gemini.denx.de> References: <1258239796-21528-1-git-send-email-albert.aribaud@free.fr> <1258239796-21528-2-git-send-email-albert.aribaud@free.fr> <20091118221716.80D933F6C2@gemini.denx.de> Message-ID: <4B124E1F.6030008@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk a ?crit : > Dear Albert Aribaud, >> diff --git a/include/asm-arm/arch-orion5x/88f5182.h b/include/asm-arm/arch-orion5x/88f5182.h >> new file mode 100644 >> index 0000000..b16b23f >> --- /dev/null >> +++ b/include/asm-arm/arch-orion5x/88f5182.h > > 88f5182 is a terrible file name. Can you not come up with something > more descriptive, please? (Pre)fixed: file is now mv88f5182.h. That's the best I can do since 88F5182 is actually the SoC variant 'name'. Expect 'mv88f5181.h', 'mv88f5281.h' in the future. >> diff --git a/include/asm-arm/arch-orion5x/gpio.h b/include/asm-arm/arch-orion5x/gpio.h >> new file mode 100644 >> index 0000000..58592ad >> --- /dev/null >> +++ b/include/asm-arm/arch-orion5x/gpio.h > ... >> +/* >> + * Orion5x-specific GPIO API >> + */ > > Why do we need an Orion5x-specific GPIO API? Can't we use something > that is more general? I've looked at the current u-boot code and have found no generic GPIO API -- and six different, specific ones. Is there an effort going on to generalize this? Amicalement, -- Albert.