public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c
Date: Thu, 03 Dec 2009 07:48:31 +0100	[thread overview]
Message-ID: <4B175F3F.2060400@denx.de> (raw)
In-Reply-To: <20091202223556.211214C025@gemini.denx.de>

Hello Wolfgang,

Wolfgang Denk schrieb:
> Dear Pratap Chandu,
> 
> In message <1258034305-31770-1-git-send-email-pratap.rrke@gmail.com> you wrote:
>> There is some dead code enclosed by #if 0 .... #endif in the file common/cmd_i2c.c
>> This patch removes the dead code.
>>
>> Signed-off-by: Pratap Chandu <pratap.rrke@gmail.com>
>> ---
>>  common/cmd_i2c.c |    8 --------
>>  1 files changed, 0 insertions(+), 8 deletions(-)
> 
> Applied, thanks.
> 
> Heiko, I hope this is OK with you.

Hmm.. not really, my last comment on this was:

http://lists.denx.de/pipermail/u-boot/2009-November/064245.html

I don;t know, if this was ever used, but we should make this
as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-12-03  6:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12 13:58 [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c Pratap Chandu
2009-12-02 22:35 ` Wolfgang Denk
2009-12-03  6:48   ` Heiko Schocher [this message]
2009-12-04 21:45     ` Wolfgang Denk
2009-12-05 10:54       ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B175F3F.2060400@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox