From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c
Date: Sat, 05 Dec 2009 11:54:52 +0100 [thread overview]
Message-ID: <4B1A3BFC.6010807@denx.de> (raw)
In-Reply-To: <20091204214549.A24773F6E3@gemini.denx.de>
Hello Wolfgang,
Wolfgang Denk wrote:
> In message <4B175F3F.2060400@denx.de> you wrote:
>>> Applied, thanks.
>>>
>>> Heiko, I hope this is OK with you.
>> Hmm.. not really, my last comment on this was:
>
> Ouch, sorry.
No probelm.
>> http://lists.denx.de/pipermail/u-boot/2009-November/064245.html
>
> I missed that, sorry. This was in another thread, not connected with
> the patch.
>
>> I don;t know, if this was ever used, but we should make this
>> as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.
>
> What do you suggest? Shall I revert the patch, or can you provide a
> new commit to re-add this feature? [But then, it would be unused code,
> which we don't want to add, right?]
I actually vote for removing the code, so I sent soon a patch, which
fixes the comment.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2009-12-05 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 13:58 [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c Pratap Chandu
2009-12-02 22:35 ` Wolfgang Denk
2009-12-03 6:48 ` Heiko Schocher
2009-12-04 21:45 ` Wolfgang Denk
2009-12-05 10:54 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1A3BFC.6010807@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox