From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Sat, 05 Dec 2009 11:54:52 +0100 Subject: [U-Boot] [PATCH] Removes dead code in the file common/cmd_i2c.c In-Reply-To: <20091204214549.A24773F6E3@gemini.denx.de> References: <1258034305-31770-1-git-send-email-pratap.rrke@gmail.com> <20091202223556.211214C025@gemini.denx.de> <4B175F3F.2060400@denx.de> <20091204214549.A24773F6E3@gemini.denx.de> Message-ID: <4B1A3BFC.6010807@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, Wolfgang Denk wrote: > In message <4B175F3F.2060400@denx.de> you wrote: >>> Applied, thanks. >>> >>> Heiko, I hope this is OK with you. >> Hmm.. not really, my last comment on this was: > > Ouch, sorry. No probelm. >> http://lists.denx.de/pipermail/u-boot/2009-November/064245.html > > I missed that, sorry. This was in another thread, not connected with > the patch. > >> I don;t know, if this was ever used, but we should make this >> as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE. > > What do you suggest? Shall I revert the patch, or can you provide a > new commit to re-add this feature? [But then, it would be unused code, > which we don't want to add, right?] I actually vote for removing the code, so I sent soon a patch, which fixes the comment. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany