[U-Boot] [PATCH] fix nfs symlink name corruption

[U-Boot] [PATCH] fix nfs symlink name corruption

[Ed Swarthout]

An off by one error may cause nfs readlink lookup fail if
nfs_path_buff has non-zero data from a previous use.

Loading: *** ERROR: File lookup fail

Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
---
 net/nfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/nfs.c b/net/nfs.c
index 27395fb..c39f616 100644
--- a/net/nfs.c
+++ b/net/nfs.c
@@ -516,7 +516,7 @@ nfs_readlink_reply (uchar *pkt, unsigned len)
 		strcat (nfs_path, "/");
 		pathlen = strlen(nfs_path);
 		memcpy (nfs_path+pathlen, (uchar *)&(rpc_pkt.u.reply.data[2]), rlen);
-		nfs_path[pathlen+rlen+1] = 0;
+		nfs_path[pathlen + rlen] = 0;
 	} else {
 		memcpy (nfs_path, (uchar *)&(rpc_pkt.u.reply.data[2]), rlen);
 		nfs_path[rlen] = 0;
-- 
1.5.6.5

[U-Boot] [PATCH] fix nfs symlink name corruption

[Wolfgang Denk]

Dear Ed Swarthout,

In message <1258620448-20960-1-git-send-email-Ed.Swarthout@freescale.com> you wrote:
> An off by one error may cause nfs readlink lookup fail if
> nfs_path_buff has non-zero data from a previous use.
> 
> Loading: *** ERROR: File lookup fail
> 
> Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
> ---
>  net/nfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied.

Ben, I hope this is OK with you. Looked obvious to me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I can't understand it. I can't even understand  the  people  who  can
understand it.                    - Queen Juliana of the Netherlands.

[U-Boot] [PATCH] fix nfs symlink name corruption

[Ben Warren]

Wolfgang Denk wrote:
> Dear Ed Swarthout,
>
> In message <1258620448-20960-1-git-send-email-Ed.Swarthout@freescale.com> you wrote:
>   
>> An off by one error may cause nfs readlink lookup fail if
>> nfs_path_buff has non-zero data from a previous use.
>>
>> Loading: *** ERROR: File lookup fail
>>
>> Signed-off-by: Ed Swarthout <Ed.Swarthout@freescale.com>
>> ---
>>  net/nfs.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>     
>
> Applied.
>
> Ben, I hope this is OK with you. Looked obvious to me.
>
> Best regards,
>
> Wolfgang Denk
>
>   
Fine with me.  Thanks for taking care of this.

Ben