public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] LAN91C96: Enable NET_MULTI LAN driver
Date: Mon, 7 Dec 2009 15:47:28 -0600	[thread overview]
Message-ID: <4B1D77F0.8000205@ti.com> (raw)
In-Reply-To: <4B1D6F24.60501@gmail.com>

Ben Warren had written, on 12/07/2009 03:09 PM, the following:
> Nishanth,
> 
> Nishanth Menon wrote:
>> This modification is NOT tested on any of the
>> platforms modified as I dont have them. please
>> help by testing+building+fixing
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> Cc: Andrea Scian <andrea.scian@dave-tech.it>
>> Cc: Ben Warren <biggerbadderben@gmail.com>
>> Cc: Dave Peverley <dpeverley@mpc-data.co.uk>
>> Cc: George G. Davis <gdavis@mvista.com>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>> Cc: Nishant Kamat <nskamat@ti.com>
>> Cc: Richard Woodruff <r-woodruff2@ti.com>
>> Cc: Rishi Bhattacharya <rishi@ti.com>
>> Cc: Sandeep Paulraj <s-paulraj@ti.com>
>> ---
>>  board/apollon/apollon.c       |   12 +++++++-----
>>  include/configs/B2.h          |    2 +-
>>  include/configs/apollon.h     |    3 ++-
>>  include/configs/assabet.h     |    3 ++-
>>  include/configs/gcplus.h      |    3 ++-
>>  include/configs/lubbock.h     |    3 ++-
>>  include/configs/omap1510inn.h |    3 ++-
>>  include/configs/omap1610h2.h  |    3 ++-
>>  include/configs/omap1610inn.h |    3 ++-
>>  include/configs/omap2420h4.h  |    3 ++-
>>  include/configs/omap5912osk.h |    3 ++-
>>  include/configs/omap730p2.h   |    3 ++-
>>  include/configs/pleb2.h       |    6 ++++--
>>  13 files changed, 32 insertions(+), 18 deletions(-)
>>   
> You've update the config files for a bunch of boards, but have not added 
> board_eth_init() functions for them.  Am I missing something?  If this 
> is indeed the case, I can't push these patches upstream from the net 
> tree because the associated boards will break.
I have added the init where they have been previously used for the old 
lan91c96 driver. I think the only one which was actively using it was 
apollon, which means the rest of the platforms probably dont use the old 
lan driver properly in the first place. I have maintained status quo 
there instead of introducing a change which may break them.

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2009-12-07 21:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16  5:06 [U-Boot] [PATCH 0/3] enable CONFIG_NET_MULTI for LAN91C96 Nishanth Menon
2009-10-16  5:06 ` [U-Boot] [PATCH 1/3] NET: LAN91C96 CONFIG_NET_MULTIify Nishanth Menon
2009-10-16  5:06   ` [U-Boot] [PATCH 2/3] TI OMAP3: SDP3430 FIX NET_MULTI Warning Nishanth Menon
2009-10-16  5:06     ` [U-Boot] [PATCH 3/3] LAN91C96: Enable NET_MULTI LAN driver Nishanth Menon
2009-10-18 19:57       ` Tom
2009-10-19  0:24         ` Ben Warren
2009-11-10  6:27       ` Ben Warren
2009-12-07 21:09       ` Ben Warren
2009-12-07 21:47         ` Nishanth Menon [this message]
2009-12-14  6:46           ` Ben Warren
2009-10-16  5:56     ` [U-Boot] [PATCH 2/3] TI OMAP3: SDP3430 FIX NET_MULTI Warning Dirk Behme
2009-11-10  6:25     ` Ben Warren
2009-11-10  6:22   ` [U-Boot] [PATCH 1/3] NET: LAN91C96 CONFIG_NET_MULTIify Ben Warren
2009-11-22 23:01   ` Wolfgang Denk
2009-11-23 11:54     ` Menon, Nishanth
2009-10-16 16:29 ` [U-Boot] [PATCH 0/3] enable CONFIG_NET_MULTI for LAN91C96 Ben Warren
2009-10-16 16:39   ` Menon, Nishanth
2009-11-09 17:23   ` Menon, Nishanth
2009-11-09 18:10     ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B1D77F0.8000205@ti.com \
    --to=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox