From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Date: Mon, 7 Dec 2009 15:47:28 -0600 Subject: [U-Boot] [PATCH 3/3] LAN91C96: Enable NET_MULTI LAN driver In-Reply-To: <4B1D6F24.60501@gmail.com> References: <1255669597-10607-1-git-send-email-nm@ti.com> <1255669597-10607-2-git-send-email-nm@ti.com> <1255669597-10607-3-git-send-email-nm@ti.com> <1255669597-10607-4-git-send-email-nm@ti.com> <4B1D6F24.60501@gmail.com> Message-ID: <4B1D77F0.8000205@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Ben Warren had written, on 12/07/2009 03:09 PM, the following: > Nishanth, > > Nishanth Menon wrote: >> This modification is NOT tested on any of the >> platforms modified as I dont have them. please >> help by testing+building+fixing >> >> Signed-off-by: Nishanth Menon >> Cc: Andrea Scian >> Cc: Ben Warren >> Cc: Dave Peverley >> Cc: George G. Davis >> Cc: Kyungmin Park >> Cc: Nishant Kamat >> Cc: Richard Woodruff >> Cc: Rishi Bhattacharya >> Cc: Sandeep Paulraj >> --- >> board/apollon/apollon.c | 12 +++++++----- >> include/configs/B2.h | 2 +- >> include/configs/apollon.h | 3 ++- >> include/configs/assabet.h | 3 ++- >> include/configs/gcplus.h | 3 ++- >> include/configs/lubbock.h | 3 ++- >> include/configs/omap1510inn.h | 3 ++- >> include/configs/omap1610h2.h | 3 ++- >> include/configs/omap1610inn.h | 3 ++- >> include/configs/omap2420h4.h | 3 ++- >> include/configs/omap5912osk.h | 3 ++- >> include/configs/omap730p2.h | 3 ++- >> include/configs/pleb2.h | 6 ++++-- >> 13 files changed, 32 insertions(+), 18 deletions(-) >> > You've update the config files for a bunch of boards, but have not added > board_eth_init() functions for them. Am I missing something? If this > is indeed the case, I can't push these patches upstream from the net > tree because the associated boards will break. I have added the init where they have been previously used for the old lan91c96 driver. I think the only one which was actively using it was apollon, which means the rest of the platforms probably dont use the old lan driver properly in the first place. I have maintained status quo there instead of introducing a change which may break them. -- Regards, Nishanth Menon