[U-Boot] [PATCH] Stop stack clobbering in microblaze-generic.

[U-Boot] [PATCH] Stop stack clobbering in microblaze-generic.

[Graeme Smecher]

From: Graeme Smecher <gsmecher@tonka.atlantic.home>

A typo caused the stack and malloc regions to overlap, which prevented
mem_malloc_init() from returning. This commit makes the memory layout match
the example described in include/configs/microblaze-generic.h
---
 include/configs/microblaze-generic.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h
index b486c77..9b1569a 100644
--- a/include/configs/microblaze-generic.h
+++ b/include/configs/microblaze-generic.h
@@ -146,7 +146,7 @@
 #define	CONFIG_SYS_MALLOC_BASE		(CONFIG_SYS_MONITOR_BASE - CONFIG_SYS_MALLOC_LEN)
 
 /* stack */
-#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MONITOR_BASE
+#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MALLOC_BASE
 
 /*#define	RAMENV */
 #define	FLASH
-- 
1.6.5

[U-Boot] [PATCH] Stop stack clobbering in microblaze-generic.

[Wolfgang Denk]

Dear Michal,

In message <1260202197-1949-1-git-send-email-graeme.smecher@mail.mcgill.ca> you wrote:
> From: Graeme Smecher <gsmecher@tonka.atlantic.home>
> 
> A typo caused the stack and malloc regions to overlap, which prevented
> mem_malloc_init() from returning. This commit makes the memory layout match
> the example described in include/configs/microblaze-generic.h
> ---
>  include/configs/microblaze-generic.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Please send a pull request if you want this to go into v2009.11

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe does not have laws - it has habits, and  habits  can  be
broken.

[U-Boot] [PATCH] Stop stack clobbering in microblaze-generic.

[Michal Simek]

Hi Graeme,

Graeme Smecher wrote:
> From: Graeme Smecher <gsmecher@tonka.atlantic.home>
> 
> A typo caused the stack and malloc regions to overlap, which prevented
> mem_malloc_init() from returning. This commit makes the memory layout match
> the example described in include/configs/microblaze-generic.h

I added your Sign-off-by line and all microblaze patches should have 
"microblaze:" prefix in subject. I fixed these things and your patch is 
in microblaze repo.

Thanks,
Michal

> ---
>  include/configs/microblaze-generic.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h
> index b486c77..9b1569a 100644
> --- a/include/configs/microblaze-generic.h
> +++ b/include/configs/microblaze-generic.h
> @@ -146,7 +146,7 @@
>  #define	CONFIG_SYS_MALLOC_BASE		(CONFIG_SYS_MONITOR_BASE - CONFIG_SYS_MALLOC_LEN)
>  
>  /* stack */
> -#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MONITOR_BASE
> +#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MALLOC_BASE
>  
>  /*#define	RAMENV */
>  #define	FLASH


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

[U-Boot] [PATCH] Stop stack clobbering in microblaze-generic.

[Graeme Smecher]

Hi Michal,

Michal Simek wrote:
> Hi Graeme,
>
> Graeme Smecher wrote:
>   
>> From: Graeme Smecher <gsmecher@tonka.atlantic.home>
>>
>> A typo caused the stack and malloc regions to overlap, which prevented
>> mem_malloc_init() from returning. This commit makes the memory layout match
>> the example described in include/configs/microblaze-generic.h
>>     
>
> I added your Sign-off-by line and all microblaze patches should have 
> "microblaze:" prefix in subject. I fixed these things and your patch is 
> in microblaze repo.
>   

Thanks. However, I notice (and you've probably noticed too) that the 
"From" address in the patch is bogus. Please let me know if you'd like 
me to resubmit with a valid e-mail. Sorry for the extra hassle.

best,
Graeme

[U-Boot] [PATCH] Stop stack clobbering in microblaze-generic.

[Michal Simek]

Graeme Smecher wrote:
> Hi Michal,
> 
> Michal Simek wrote:
>> Hi Graeme,
>>
>> Graeme Smecher wrote:
>>  
>>> From: Graeme Smecher <gsmecher@tonka.atlantic.home>
>>>
>>> A typo caused the stack and malloc regions to overlap, which prevented
>>> mem_malloc_init() from returning. This commit makes the memory layout 
>>> match
>>> the example described in include/configs/microblaze-generic.h
>>>     
>>
>> I added your Sign-off-by line and all microblaze patches should have 
>> "microblaze:" prefix in subject. I fixed these things and your patch 
>> is in microblaze repo.
>>   
> 
> Thanks. However, I notice (and you've probably noticed too) that the 
> "From" address in the patch is bogus. Please let me know if you'd like 
> me to resubmit with a valid e-mail. Sorry for the extra hassle.

You can check it alone.
http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary


No worries about,
Michal

> 
> best,
> Graeme
> 


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian