From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Weber <swirl@gmx.li>
Date: Tue, 08 Dec 2009 21:38:42 +0100
Subject: [U-Boot] [PATCH] Fix debug output.
In-Reply-To: <20091207200934.2CDC03F6CC@gemini.denx.de>
References: <1260177679-18337-1-git-send-email-weber@corscience.de>	<20091207120754.AE6EA3F6CC@gemini.denx.de>	<4B1CFEF3.7080302@corscience.de>
	<20091207200934.2CDC03F6CC@gemini.denx.de>
Message-ID: <4B1EB952.1070904@gmx.li>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk schrieb:
> Dear Thomas Weber,
>
> In message <4B1CFEF3.7080302@corscience.de> you wrote:
>   
>>> Which problem is this supposed to fix? 
>>>       
> ...
>   
>> In commit 60f61e6d7655400bb785a2ef637581679941f6d1 the following calls
>> where changed.
>>
>> -       DM9000_DMP_PACKET("eth_send", packet, length);
>> +       DM9000_DMP_PACKET(__func__ , packet, length);
>>
>> -                       DM9000_DMP_PACKET("eth_rx", rdptr, RxLen);
>> +                       DM9000_DMP_PACKET(__func__ , rdptr, RxLen);
>>
>> The identifier __func__ is used to call this macro. Formerly it was a
>> string "eth_send" for the function name.
>>
>> printf("eth_send" ":length ...") worked,  but printf(__func__ ":length
>> ...") doesn't compile. (tested with gcc-4.4.1)
>>     
>
> Well, and exactly this is valuable information which should be
> included into the commit message.
>
> Indeed, neither __func__ nor __FUNCTION__ can be concatenated; for
> some reason gcc seems to consider these as strings, but not as string
> constants. Dunno why; probably there is a good reason for this, but
> it looks stupid to me.
>
> Best regards,
>
> Wolfgang Denk
>
>   
Hello,

should  I resend the better formatted patch with a proper subject line
and a more detailed comment? How to name the patch? [Patch V2] ?


Thomas Weber