From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH]Fix checksum to handle odd-length packet
Date: Wed, 09 Dec 2009 21:53:46 -0500 [thread overview]
Message-ID: <4B2062BA.50208@gmail.com> (raw)
In-Reply-To: <CB2DD11991B27C4F99935E6229450D3204E5D210@STORK.scenix.com>
Hi Greg,
Greg Ren wrote:
> Hi Ben:
>
> Ben Warren wrote:
>> Please don't top post.
>> While I agree that the network code should handle this properly, how
> do
>> you end up with odd-length packets? U-boot's been around for years
> and
>> nobody else has had this problem...
>
> I simply ping it with odd length. I also checked the latest u-boot
> online and the issue has not been fixed. It could be that most usage had
> involved only with even length packet, and no one had seen this issue.
> It is a boot loader and may not get used as often as some popular
> applications.
>
> Regards
>
> Greg
When you respin your patch, please put the "ping with an odd length
causes an incorrect checksum bug" in the commit message for future
reference.
Thanks,
gvb
next prev parent reply other threads:[~2009-12-10 2:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 22:23 [U-Boot] [PATCH]Fix checksum to handle odd-length packet Greg Ren
2009-12-03 11:31 ` Wolfgang Denk
2009-12-03 12:28 ` Joakim Tjernlund
2009-12-03 14:08 ` Wolfgang Denk
2009-12-03 14:41 ` Joakim Tjernlund
2009-12-03 16:18 ` Greg Ren
2009-12-08 22:27 ` Greg Ren
2009-12-08 23:43 ` Joakim Tjernlund
2009-12-08 23:53 ` Greg Ren
2009-12-09 1:52 ` Ben Warren
2009-12-09 2:16 ` Greg Ren
2009-12-10 2:53 ` Jerry Van Baren [this message]
2009-12-10 16:36 ` Greg Ren
2009-12-10 18:21 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2062BA.50208@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox