From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gvb.uboot@gmail.com>
Date: Wed, 09 Dec 2009 21:53:46 -0500
Subject: [U-Boot] [PATCH]Fix checksum to handle odd-length packet
In-Reply-To: <CB2DD11991B27C4F99935E6229450D3204E5D210@STORK.scenix.com>
References: <CB2DD11991B27C4F99935E6229450D3204E5CB91@STORK.scenix.com>	<20091203113105.EA2AEE6D391@gemini.denx.de>	<CB2DD11991B27C4F99935E6229450D3204E5D1A3@STORK.scenix.com>	<OFA9371396.57A178ED-ONC1257686.00821E17-C1257686.00824FEE@transmode.se>	<CB2DD11991B27C4F99935E6229450D3204E5D1DA@STORK.scenix.com>	<4B1F02DA.9090908@gmail.com>
	<CB2DD11991B27C4F99935E6229450D3204E5D210@STORK.scenix.com>
Message-ID: <4B2062BA.50208@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Greg,

Greg Ren wrote:
> Hi Ben:
> 
> Ben Warren wrote:
>> Please don't top post.
>> While I agree that the network code should handle this properly, how
> do 
>> you end up with odd-length packets?  U-boot's been around for years
> and 
>> nobody else has had this problem...
> 
> I simply ping it with odd length. I also checked the latest u-boot
> online and the issue has not been fixed. It could be that most usage had
> involved only with even length packet, and no one had seen this issue.
> It is a boot loader and may not get used as often as some popular
> applications.
> 
> Regards
> 
> Greg

When you respin your patch, please put the "ping with an odd length 
causes an incorrect checksum bug" in the commit message for future 
reference.

Thanks,
gvb