From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH]Fix checksum to handle odd-length packet
Date: Thu, 10 Dec 2009 13:21:54 -0500 [thread overview]
Message-ID: <4B213C42.3090506@ge.com> (raw)
In-Reply-To: <CB2DD11991B27C4F99935E6229450D3204E5D39B@STORK.scenix.com>
Greg Ren wrote:
> Jerry Van Baren wrote:
>
>> When you respin your patch, please put the "ping with an odd length
>> causes an incorrect checksum bug" in the commit message for future
>> reference.
>
>> Thanks,
>> gvb
>
> The change was to the general checksum calculation. So there is enough
> reason to believe that any odd-length packet may suffer the same fate.
> Ping is just an easier way to test and verify the fix.
>
> regards
> Greg Ren
Understood. My point was your original commit message did not identify
*how* to exercise the bug (i.e. ping with an odd length packet). That
is very valuable information because it helps us remember what was
broken and how to test both the brokenness and the fix.
Thanks,
gvb
prev parent reply other threads:[~2009-12-10 18:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 22:23 [U-Boot] [PATCH]Fix checksum to handle odd-length packet Greg Ren
2009-12-03 11:31 ` Wolfgang Denk
2009-12-03 12:28 ` Joakim Tjernlund
2009-12-03 14:08 ` Wolfgang Denk
2009-12-03 14:41 ` Joakim Tjernlund
2009-12-03 16:18 ` Greg Ren
2009-12-08 22:27 ` Greg Ren
2009-12-08 23:43 ` Joakim Tjernlund
2009-12-08 23:53 ` Greg Ren
2009-12-09 1:52 ` Ben Warren
2009-12-09 2:16 ` Greg Ren
2009-12-10 2:53 ` Jerry Van Baren
2009-12-10 16:36 ` Greg Ren
2009-12-10 18:21 ` Jerry Van Baren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B213C42.3090506@ge.com \
--to=gerald.vanbaren@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox