From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@ge.com>
Date: Thu, 10 Dec 2009 13:21:54 -0500
Subject: [U-Boot] [PATCH]Fix checksum to handle odd-length packet
In-Reply-To: <CB2DD11991B27C4F99935E6229450D3204E5D39B@STORK.scenix.com>
References: <CB2DD11991B27C4F99935E6229450D3204E5CB91@STORK.scenix.com>	<20091203113105.EA2AEE6D391@gemini.denx.de>	<CB2DD11991B27C4F99935E6229450D3204E5D1A3@STORK.scenix.com>	<OFA9371396.57A178ED-ONC1257686.00821E17-C1257686.00824FEE@transmode.se>	<CB2DD11991B27C4F99935E6229450D3204E5D1DA@STORK.scenix.com>	<4B1F02DA.9090908@gmail.com>	<CB2DD11991B27C4F99935E6229450D3204E5D210@STORK.scenix.com>	<4B2062BA.50208@gmail.com>
	<CB2DD11991B27C4F99935E6229450D3204E5D39B@STORK.scenix.com>
Message-ID: <4B213C42.3090506@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Greg Ren wrote:
> Jerry Van Baren wrote:
> 
>> When you respin your patch, please put the "ping with an odd length 
>> causes an incorrect checksum bug" in the commit message for future 
>> reference.
> 
>> Thanks,
>> gvb
> 
> The change was to the general checksum calculation. So there is enough
> reason to believe that any odd-length packet may suffer the same fate.
> Ping is just an easier way to test and verify the fix.
> 
> regards
> Greg Ren

Understood.  My point was your original commit message did not identify 
*how* to exercise the bug (i.e. ping with an odd length packet).  That 
is very valuable information because it helps us remember what was 
broken and how to test both the brokenness and the fix.

Thanks,
gvb