[U-Boot] [PATCH] OMAP3EVM: Increase bootargs string length.

[U-Boot] [PATCH] OMAP3EVM: Increase bootargs string length.

[Sriramakrishnan]

Increase the bootargs string length as multiple options
(especially for Video settings) are passed to the kernel
through bootargs. Also increase the number of args.

Signed-off-by: Sriramakrishnan <srk@ti.com>
---
 include/configs/omap3_evm.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
index a5514ae..fe7b0e2 100644
--- a/include/configs/omap3_evm.h
+++ b/include/configs/omap3_evm.h
@@ -200,11 +200,11 @@
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
 #define CONFIG_SYS_PROMPT_HUSH_PS2	"> "
 #define CONFIG_SYS_PROMPT		V_PROMPT
-#define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
+#define CONFIG_SYS_CBSIZE		512	/* Console I/O Buffer Size */
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
 					sizeof(CONFIG_SYS_PROMPT) + 16)
-#define CONFIG_SYS_MAXARGS		16	/* max number of command */
+#define CONFIG_SYS_MAXARGS		32	/* max number of command */
 						/* args */
 /* Boot Argument Buffer Size */
 #define CONFIG_SYS_BARGSIZE		(CONFIG_SYS_CBSIZE)
-- 
1.6.2.4

[U-Boot] [PATCH] OMAP3EVM: Increase bootargs string length.

[Dirk Behme]

On 17.12.2009 14:29, Sriramakrishnan wrote:
> Increase the bootargs string length as multiple options
> (especially for Video settings) are passed to the kernel
> through bootargs. Also increase the number of args.
>
> Signed-off-by: Sriramakrishnan<srk@ti.com>
> ---
>   include/configs/omap3_evm.h |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
> index a5514ae..fe7b0e2 100644
> --- a/include/configs/omap3_evm.h
> +++ b/include/configs/omap3_evm.h
> @@ -200,11 +200,11 @@
>   #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
>   #define CONFIG_SYS_PROMPT_HUSH_PS2	">  "
>   #define CONFIG_SYS_PROMPT		V_PROMPT
> -#define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
> +#define CONFIG_SYS_CBSIZE		512	/* Console I/O Buffer Size */
>   /* Print Buffer Size */
>   #define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
>   					sizeof(CONFIG_SYS_PROMPT) + 16)
> -#define CONFIG_SYS_MAXARGS		16	/* max number of command */
> +#define CONFIG_SYS_MAXARGS		32	/* max number of command */
>   						/* args */
>   /* Boot Argument Buffer Size */
>   #define CONFIG_SYS_BARGSIZE		(CONFIG_SYS_CBSIZE)

Should we do this for some more OMAP3 boards, too? E.g. Overo and 
Beagle? Or for all OMAP3 boards?

Best regards

Dirk

[U-Boot] [PATCH] OMAP3EVM: Increase bootargs string length.

[Govindarajan, Sriramakrishnan]

 
> On 17.12.2009 14:29, Sriramakrishnan wrote:
> > Increase the bootargs string length as multiple options
> > (especially for Video settings) are passed to the kernel
> > through bootargs. Also increase the number of args.
> >
> > Signed-off-by: Sriramakrishnan<srk@ti.com>
> > ---
> >   include/configs/omap3_evm.h |    4 ++--
> >   1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
> > index a5514ae..fe7b0e2 100644
> > --- a/include/configs/omap3_evm.h
> > +++ b/include/configs/omap3_evm.h
> > @@ -200,11 +200,11 @@
> >   #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
> >   #define CONFIG_SYS_PROMPT_HUSH_PS2	">  "
> >   #define CONFIG_SYS_PROMPT		V_PROMPT
> > -#define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
> > +#define CONFIG_SYS_CBSIZE		512	/* Console I/O Buffer Size */
> >   /* Print Buffer Size */
> >   #define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
> >   					sizeof(CONFIG_SYS_PROMPT) + 16)
> > -#define CONFIG_SYS_MAXARGS		16	/* max number of command */
> > +#define CONFIG_SYS_MAXARGS		32	/* max number of command */
> >   						/* args */
> >   /* Boot Argument Buffer Size */
> >   #define CONFIG_SYS_BARGSIZE		(CONFIG_SYS_CBSIZE)
> 
> Should we do this for some more OMAP3 boards, too? E.g. Overo and
> Beagle? Or for all OMAP3 boards?
> 
> Best regards
> 
> Dirk

I believe the change is relevant for other OMAP3 boards as well. I can repost the patch with changes for all OMAP3 boards but I will not be able to 
Test this on boards other than omap3evm.

Regards
Sriram

[U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.

[Tom]

Dirk Behme wrote:
> On 17.12.2009 14:29, Sriramakrishnan wrote:
>> Increase the bootargs string length as multiple options
>> (especially for Video settings) are passed to the kernel
>> through bootargs. Also increase the number of args.

<snip>
> 
> Should we do this for some more OMAP3 boards, too? E.g. Overo and 
> Beagle? Or for all OMAP3 boards?
> 

It seems like a lot of the omap3 boards share common config options.
What do you think about consolidating the common options to
a sub config file ?

Tom

> Best regards
> 
> Dirk
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.

[Premi, Sanjeev]

 

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Tom
> Sent: Thursday, December 17, 2009 9:25 PM
> To: Dirk Behme
> Cc: u-boot at lists.denx.de
> Subject: [U-Boot] RFC common omap3 subconfig ? was Re: 
> [PATCH] OMAP3EVM: Increase bootargs string length.
> 
> Dirk Behme wrote:
> > On 17.12.2009 14:29, Sriramakrishnan wrote:
> >> Increase the bootargs string length as multiple options
> >> (especially for Video settings) are passed to the kernel
> >> through bootargs. Also increase the number of args.
> 
> <snip>
> > 
> > Should we do this for some more OMAP3 boards, too? E.g. Overo and 
> > Beagle? Or for all OMAP3 boards?
> > 
> 
> It seems like a lot of the omap3 boards share common config options.
> What do you think about consolidating the common options to
> a sub config file ?

Seems a good idea; only if we are sure that the next board doesn't
break the current list of common configs. Else, we would be having
patches to move config options back to board specific files.

~sanjeev

> 
> Tom
> 
> > Best regards
> > 
> > Dirk
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 

[U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.

[Dirk Behme]

On 17.12.2009 16:58, Premi, Sanjeev wrote:
>
>
>> -----Original Message-----
>> From: u-boot-bounces at lists.denx.de
>> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Tom
>> Sent: Thursday, December 17, 2009 9:25 PM
>> To: Dirk Behme
>> Cc: u-boot at lists.denx.de
>> Subject: [U-Boot] RFC common omap3 subconfig ? was Re:
>> [PATCH] OMAP3EVM: Increase bootargs string length.
>>
>> Dirk Behme wrote:
>>> On 17.12.2009 14:29, Sriramakrishnan wrote:
>>>> Increase the bootargs string length as multiple options
>>>> (especially for Video settings) are passed to the kernel
>>>> through bootargs. Also increase the number of args.
>>
>> <snip>
>>>
>>> Should we do this for some more OMAP3 boards, too? E.g. Overo and
>>> Beagle? Or for all OMAP3 boards?
>>>
>>
>> It seems like a lot of the omap3 boards share common config options.
>> What do you think about consolidating the common options to
>> a sub config file ?
>
> Seems a good idea; only if we are sure that the next board doesn't
> break the current list of common configs. Else, we would be having
> patches to move config options back to board specific files.

Does Wolfgang have a basic opinion about sub-configs for configuration 
stuff common for similar boards?

Best regards

Dirk

[U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.

[Stefan Roese]

Hi Dirk,

On Thursday 17 December 2009 17:07:01 Dirk Behme wrote:
> >> It seems like a lot of the omap3 boards share common config options.
> >> What do you think about consolidating the common options to
> >> a sub config file ?
> >
> > Seems a good idea; only if we are sure that the next board doesn't
> > break the current list of common configs. Else, we would be having
> > patches to move config options back to board specific files.
> 
> Does Wolfgang have a basic opinion about sub-configs for configuration
> stuff common for similar boards?

We already have some similar common config files. Take a look for example at 
the AMCC config header:

include/configs/amcc-common.h

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

[U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.

[Heiko Schocher]

Hello Stefan,

Stefan Roese wrote:
> On Thursday 17 December 2009 17:07:01 Dirk Behme wrote:
>>>> It seems like a lot of the omap3 boards share common config options.
>>>> What do you think about consolidating the common options to
>>>> a sub config file ?
>>> Seems a good idea; only if we are sure that the next board doesn't
>>> break the current list of common configs. Else, we would be having
>>> patches to move config options back to board specific files.
>> Does Wolfgang have a basic opinion about sub-configs for configuration
>> stuff common for similar boards?
> 
> We already have some similar common config files. Take a look for example at 
> the AMCC config header:
> 
> include/configs/amcc-common.h

I vote for collecting "common config files" in a subdir:

include/configs/common

for example:
include/configs/common/mpc83xx.h

collects all common config options for 83xx boards.
and so on for all other architectures/manufacturer ...

And a "#include "configs/common/..." provides enough
information, what will come in with that include ...

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.

[Stefan Roese]

Hi Heiko,

On Thursday 17 December 2009 19:23:58 Heiko Schocher wrote:
> > We already have some similar common config files. Take a look for example
> > at the AMCC config header:
> >
> > include/configs/amcc-common.h
> 
> I vote for collecting "common config files" in a subdir:
> 
> include/configs/common
> 
> for example:
> include/configs/common/mpc83xx.h
> 
> collects all common config options for 83xx boards.
> and so on for all other architectures/manufacturer ...
> 
> And a "#include "configs/common/..." provides enough
> information, what will come in with that include ...

Yes, such a directory could make sense. But please note that we already have 
something similar:

include/asm-ppc/config.h

The other architectures have this file as well, but most of them don't define 
much in it. Not sure how to best merge/consolidate this.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de